netobserv: few env renamed; bundle now uses downstream config already

[jotak]

Summary by CodeRabbit

• Bug Fixes
  • Improved deployment handling for the web console plugin image, helping ensure the correct image is used during installs and upgrades.
  • Streamlined metrics-related deployment logic to avoid unnecessary patching steps.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jotak
Once this PR has been reviewed and has the lgtm label, please assign amoghrd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21b8d4f4-b2e7-4673-ac0a-c2bdde06ff46

📥 Commits

Reviewing files that changed from the base of the PR and between 4760b7c and 02a5827.

📒 Files selected for processing (1)

• scripts/netobserv.sh

---

📝 Walkthrough

Walkthrough

The deployment script now overrides the plugin image from RELATED_IMAGE_WEB_CONSOLE in both release and internal-build paths. The post-update metrics patch step was removed.

Changes

Web console plugin image patching

Layer / File(s)	Summary
Plugin image override flow scripts/netobserv.sh	patch_netobserv() now targets RELATED_IMAGE_WEB_CONSOLE for the plugin component, patch_unreleased_images() reads that CSV variable for internal builds, and deploy_netobserv() no longer invokes the metrics patch step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: env var renames in netobserv.sh and updated bundle behavior for downstream config.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}