sizeThatFits has to be invoked on the main thread#17
sizeThatFits has to be invoked on the main thread#17tonik173 wants to merge 1 commit intonetceteragroup:masterfrom RingierAG:main-thread-bug
Conversation
tonik173
commented
Nov 21, 2017
tonik173
commented
- method RNTweetShadowView.computeIntrinsicSize has to make sure, that sizeThatFits gets invoked in the main thread.
- _bridge property removed. Shadows native implementation.
- (dispatch_queue_t)methodQueue added to RNTwitterKitViewManager, since this module is supposed to run in main queue
| TWTRTweetView *view = [self tweetViewForMeasuring]; | ||
| defaultSize = [view sizeThatFits:CGSizeMake(width, CGFLOAT_MAX)]; // 200 is the minimum width required for a tweet | ||
| defaultSize.width = UIViewNoIntrinsicMetric; | ||
| dispatch_async(dispatch_get_main_queue(), ^{ |
There was a problem hiding this comment.
You are calling dispatch_async and in the block you are modifying deafultSize. defaultSize then gets immediately returned, i.e.you don't wait for your async call to finish.
Perhaps dispatch_sync is in order here?
| static TWTRTweetView *tweetView = nil; | ||
| static dispatch_once_t onceToken; | ||
| dispatch_once(&onceToken, ^{ | ||
| tweetView = [[TWTRTweetView alloc] initWithTweet:nil style:TWTRTweetViewStyleCompact]; |
There was a problem hiding this comment.
The problem also arises here, dispatch_sync should be called instead of dispatch_once.
There was a problem hiding this comment.
Well, alloc can be safely called in a bkgnd thread. The initWithTweet is bkgnd thread is safe also – at least thats what Apple’s code analyser says.
| @implementation RNTwitterKitViewManager | ||
|
|
||
| // this module is supposed to run in the main queue | ||
| - (dispatch_queue_t)methodQueue |
There was a problem hiding this comment.
What's the reason for moving the execution of the view manager on the main queue? It is not apparent.
There was a problem hiding this comment.
Well, it is indeed not required at the moment. However, it will be, once the library exports constants. I added it to prevent future thread problems. Since you might need it in the future anyway, the run time model remains the same. But of course, you can remove it if you wish. Should’t hurt at the moment.
2 participants
