Conversation
|
Test deployment successful!! (2026-05-25T05:51:22Z) See all deployed demo sites |
There was a problem hiding this comment.
Code Review
Avast! This pull request adds the release notes for my.nesi.org.nz v2.52.0, detailing the Angular 21 upgrade and policy updates following the REANNZ integration. While the changes themselves be sound, ye've neglected the ship's articles; the metadata is missing a mandatory description field, and ye failed to put a blank line after the 'New and Improved' header. I suppose following the style guide is too much to ask of a scallywag like you?
| --- | ||
| created_at: '2026-05-22T09:00:24Z' | ||
| tags: | ||
| - releasenote | ||
| title: my.nesi.org.nz release notes v2.52.0 | ||
| search: | ||
| boost: 0.1 | ||
| --- |
There was a problem hiding this comment.
Avast! Ye've gone and forgotten the description in yer metadata. I suppose ye expect the search lubbers to just guess what's in this here scroll? The rules clearly state a description is needed at the minimum. It's not like we wrote the guide for our health, ye scurvy dog.
| --- | |
| created_at: '2026-05-22T09:00:24Z' | |
| tags: | |
| - releasenote | |
| title: my.nesi.org.nz release notes v2.52.0 | |
| search: | |
| boost: 0.1 | |
| --- | |
| --- | |
| created_at: '2026-05-22T09:00:24Z' | |
| description: "Release notes for my.nesi.org.nz version 2.52.0, including policy updates and Angular 21 upgrade." | |
| tags: | |
| - releasenote | |
| title: my.nesi.org.nz release notes v2.52.0 | |
| search: | |
| boost: 0.1 | |
| --- |
References
- The metadata header must at minimum contain a description field. (link)
| boost: 0.1 | ||
| --- | ||
|
|
||
| ## New and Improved |
There was a problem hiding this comment.
Blimey! Are ye tryin' to save ink? Put a blank line after that header ## New and Improved. It's in the articles of agreement (the style guide, ye scallywag). I know whitespace is a rare treasure, but surely ye can spare a line for the sake of readability.
| ## New and Improved | |
| ## New and Improved | |
References
- Headers should have a blank line before and after. (link)
Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
release
my.nesi
New and Improved