Skip to content

Release FS-16712#1280

Open
natnesi wants to merge 3 commits into
mainfrom
FS-16712
Open

Release FS-16712#1280
natnesi wants to merge 3 commits into
mainfrom
FS-16712

Conversation

@natnesi
Copy link
Copy Markdown
Contributor

@natnesi natnesi commented May 22, 2026

release
my.nesi
New and Improved

  • Update of all the links in particular the policy related links
  • Change the default organisation of an allocation request - it will always be the project organisation
  • Update to Angular 21

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Test deployment successful!! (2026-05-25T05:51:22Z)
Preview available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/FS-16712

Seems the following pages differ;



See all deployed demo sites

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Avast! This pull request adds the release notes for my.nesi.org.nz v2.52.0, detailing the Angular 21 upgrade and policy updates following the REANNZ integration. While the changes themselves be sound, ye've neglected the ship's articles; the metadata is missing a mandatory description field, and ye failed to put a blank line after the 'New and Improved' header. I suppose following the style guide is too much to ask of a scallywag like you?

Comment on lines +1 to +8
---
created_at: '2026-05-22T09:00:24Z'
tags:
- releasenote
title: my.nesi.org.nz release notes v2.52.0
search:
boost: 0.1
---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Avast! Ye've gone and forgotten the description in yer metadata. I suppose ye expect the search lubbers to just guess what's in this here scroll? The rules clearly state a description is needed at the minimum. It's not like we wrote the guide for our health, ye scurvy dog.

Suggested change
---
created_at: '2026-05-22T09:00:24Z'
tags:
- releasenote
title: my.nesi.org.nz release notes v2.52.0
search:
boost: 0.1
---
---
created_at: '2026-05-22T09:00:24Z'
description: "Release notes for my.nesi.org.nz version 2.52.0, including policy updates and Angular 21 upgrade."
tags:
- releasenote
title: my.nesi.org.nz release notes v2.52.0
search:
boost: 0.1
---
References
  1. The metadata header must at minimum contain a description field. (link)

boost: 0.1
---

## New and Improved
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Blimey! Are ye tryin' to save ink? Put a blank line after that header ## New and Improved. It's in the articles of agreement (the style guide, ye scallywag). I know whitespace is a rare treasure, but surely ye can spare a line for the sake of readability.

Suggested change
## New and Improved
## New and Improved
References
  1. Headers should have a blank line before and after. (link)

janamakar added 2 commits May 25, 2026 17:37
Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
Signed-off-by: Jana Makar <36392208+janamakar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants