feat: Compatible with the extension host class of Vscode#3713
feat: Compatible with the extension host class of Vscode#3713weirongxu wants to merge 3 commits intoneoclide:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
- Coverage 82.05% 79.00% -3.06%
==========================================
Files 223 211 -12
Lines 23309 21450 -1859
Branches 5184 4875 -309
==========================================
- Hits 19127 16946 -2181
- Misses 2434 2743 +309
- Partials 1748 1761 +13
Continue to review full report at Codecov.
|
5897774 to
df1c2b3
Compare
|
It seems you need rename those class names to something like |
Thank you for your reply. I'm busy these days, I'll probably come back in a week |
The current |
I got it now, I'll make some effort, otherwise use a new name like |
df1c2b3 to
8c534be
Compare
8c534be to
20c0216
Compare
|
is this abandoned? |
|
I prefer a new module named |
|
I'm really sorry, because I couldn't focus on the development of coc related extensions for a long time before, which caused this pr to be stranded. I'll check the code and associated implementation again after a while. If I can't go on, we would use another extension to implement the compatibility layer as chemzqm said. |
|
Comes from #5235. any result or progress? |
I've try to port some vscode extensions. (like mintlify)
However, this extension uses the
MarkdownStringAPI, so it's a bit difficult to port to coc.So I tried to migrate some extension host classes to coc.
vscode source https://github.com/microsoft/vscode/blob/main/src/vs/workbench/api/common/extHostTypes.ts
Regarding the
vscode-languageserver-protocolAPI (e.g.Range.create(), which can be replaced bynew Range()).I'm not sure whether we are keeping these older APIs, I can mark it as @deprecated, but another option is to keep them backward compatible.
Please let me know if you have any suggestions about this.
TODO
DiagnosticHover