Skip to content

[BUG - WIP] Add tests showing a reprojection bug in the GeometryFileSource#21

Open
caspervdw wants to merge 1 commit into
masterfrom
casper-fixgeometryfilesource
Open

[BUG - WIP] Add tests showing a reprojection bug in the GeometryFileSource#21
caspervdw wants to merge 1 commit into
masterfrom
casper-fixgeometryfilesource

Conversation

@caspervdw

@caspervdw caspervdw commented Dec 12, 2019

Copy link
Copy Markdown
Collaborator

This seems to have to do with the presence of "no_defs": True in the CRS that is generated here:

crs = utils.get_crs(request["projection"])

@caspervdw

Copy link
Copy Markdown
Collaborator Author

How can tests pass? Locally they do not!

@caspervdw caspervdw changed the title Add tests showing a reprojection bug in the GeometryFileSource [BUG - WIP] Add tests showing a reprojection bug in the GeometryFileSource Dec 12, 2019
@caspervdw

Copy link
Copy Markdown
Collaborator Author

Discussed offline:

  • It is only occuring with pyproj >= 2
  • it has to do with the presence of "no_defs" in the fiona-generated EPSG CRS

Related to:
geopandas/geopandas#990

@caspervdw caspervdw added the bug Something isn't working label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant