Round "% successful" toward 0%, "% skipped" toward 100%#107
Open
Syeberman wants to merge 1 commit intonemequ:masterfrom
Open
Round "% successful" toward 0%, "% skipped" toward 100%#107Syeberman wants to merge 1 commit intonemequ:masterfrom
Syeberman wants to merge 1 commit intonemequ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a large number of tests with a single test failure, the "percentage tests successful" value rounds up to 100%. This can make it easy to miss that a test failed.
With this patch, the percentage successful value is always rounded towards 0%.
A similar issue occurs when a single test is skipped: the value is rounded down to 0%.
This patch rounds the percentage skipped value towards 100%.