Avoid divide-by-zero in munit_rand_state_at_most when max is zero#106
Open
Syeberman wants to merge 2 commits intonemequ:masterfrom
Open
Avoid divide-by-zero in munit_rand_state_at_most when max is zero#106Syeberman wants to merge 2 commits intonemequ:masterfrom
munit_rand_state_at_most when max is zero#106Syeberman wants to merge 2 commits intonemequ:masterfrom
Conversation
533b26e to
60ba29a
Compare
60ba29a to
389e5e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following expression will trigger a divide-by-zero error when
maxis zero:munit/munit.c
Line 971 in fbbdf14
This can occur in two places. The first is
munit_rand_int_range, whenminequalsmax:munit/munit.c
Lines 1001 to 1009 in fbbdf14
The second is in
munit_test_runner_run_test, when a parameter has a single value (possibleequals1).munit/munit.c
Line 1617 in fbbdf14
Put checks in place to avoid calling
munit_rand_state_at_mostwith amaxof zero.This is the same issue referenced in #30 and #59.