added public target-includes that provide the proper include paths fo…#2
Open
ingowald wants to merge 3 commits intonemequ:masterfrom
Open
added public target-includes that provide the proper include paths fo…#2ingowald wants to merge 3 commits intonemequ:masterfrom
ingowald wants to merge 3 commits intonemequ:masterfrom
Conversation
…r any project useing this as a git submodule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding "modern cmake"-style target-includes for the static minilzo library, such that any project using this as a git submodule will automatically import the proper directories when linking to this library.
This allows the parent CMakeLists.txt to simply do the following:
add_subdirectory(/lzo)
....
target_link_libraries(myLib PUBLIC lzo_static_lib)
include paths will then automatically get imported through the static-lib's target includes.