Address ARM review comments

specification/postgresql/DBforPostgreSQL.Management/Server.tsp

@@ -77,10 +77,8 @@ interface Servers {
    */
   delete is ArmResourceDeleteWithoutOkAsync<
     Server,
-    Response =
-      | ArmDeleteAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders &
-          Azure.Core.Foundations.RetryAfterHeader>
-      | ArmDeletedNoContentResponse
+    Response = ArmDeleteAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders &
+      Azure.Core.Foundations.RetryAfterHeader> | ArmDeletedNoContentResponse
   >;
 
   /**
@@ -138,11 +136,10 @@ interface Servers {
   start is ArmResourceActionAsyncBase<
     Server,
     BackupsLongTermRetentionRequest,
-
-      | (BackupsLongTermRetentionResponse & RequestIdResponseHeader)
-      | (ArmAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders<FinalResult = BackupsLongTermRetentionResponse> &
-          Azure.Core.Foundations.RetryAfterHeader> &
-          RequestIdResponseHeader),
+    (BackupsLongTermRetentionResponse &
+      RequestIdResponseHeader) | (ArmAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders<FinalResult = BackupsLongTermRetentionResponse> &
+      Azure.Core.Foundations.RetryAfterHeader> &
+      RequestIdResponseHeader),
     BaseParameters = Azure.ResourceManager.Foundations.DefaultBaseParameters<Server>,
     Error = CustomErrorResponse
   >;
@@ -213,49 +210,43 @@ interface Servers {
   migrateNetworkMode is ArmResourceActionAsyncBase<
     Server,
     void,
-
-      | (MigrateNetworkStatus & RequestIdResponseHeader)
-      | (ArmAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders<FinalResult = MigrateNetworkStatus> &
-          Azure.Core.Foundations.RetryAfterHeader> &
-          RequestIdResponseHeader),
+    (MigrateNetworkStatus &
+      RequestIdResponseHeader) | (ArmAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders<FinalResult = MigrateNetworkStatus> &
+      Azure.Core.Foundations.RetryAfterHeader> &
+      RequestIdResponseHeader),
     BaseParameters = Azure.ResourceManager.Foundations.DefaultBaseParameters<Server>
   >;
 
-  @doc("Begin Major Version Upgrade Prechecks.")
+  @doc("Start Major Version Upgrade Prechecks.")
   @added(Versions.v2026_04_01)
-  @action("majorVersionUpgradePrecheck")
-  majorVersionUpgradePrecheck is ArmResourceActionAsyncBase<
+  @action("startMajorVersionUpgradePrecheck")
+  startMajorVersionUpgradePrecheck is ArmResourceActionAsyncBase<
     Server,
-    MajorVersionUpgradePrecheckCreateRequest,
-    ArmResponse<MajorVersionUpgradePrecheckResponse> | ArmAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders<FinalResult = MajorVersionUpgradePrecheckResponse> &
+    StartMajorVersionUpgradePrecheckRequest,
+    ArmResponse<StartMajorVersionUpgradePrecheckResponse> | ArmAcceptedLroResponse<LroHeaders = ArmCombinedLroHeaders<FinalResult = StartMajorVersionUpgradePrecheckResponse> &
       Azure.Core.Foundations.RetryAfterHeader>,
-    BaseParameters = Azure.ResourceManager.Foundations.DefaultBaseParameters<MajorVersionUpgradePrecheckResponse>
+    BaseParameters = Azure.ResourceManager.Foundations.DefaultBaseParameters<StartMajorVersionUpgradePrecheckResponse>
   >;
 }
 
 @@maxLength(Server.name, 63);
 @@minLength(Server.name, 3);
 @@doc(Server.name, "The name of the server.");
 @@doc(Server.properties, "Properties of a server.");
-@@doc(
-  Servers.createOrUpdate::parameters.resource,
+@@doc(Servers.createOrUpdate::parameters.resource,
   "Parameters required to create a new server or to update an existing server."
 );
-@@doc(
-  Servers.update::parameters.properties,
+@@doc(Servers.update::parameters.properties,
   "Parameters required to update a server."
 );
-@@doc(
-  Servers.checkPrerequisites::parameters.body,
+@@doc(Servers.checkPrerequisites::parameters.body,
   "Request body for operation"
 );
 @@doc(Servers.start::parameters.body, "Request body for operation");
-@@doc(
-  Servers.checkNameAvailability::parameters.body,
+@@doc(Servers.checkNameAvailability::parameters.body,
   "Parameters required to check if a migration name is valid and available."
 );
 @@doc(Servers.restart::parameters.body, "Parameters to restart a server.");
-@@doc(
-  Servers.migrateNetworkMode::parameters.body,
+@@doc(Servers.migrateNetworkMode::parameters.body,
   "Parameters to migrate the network configuration of a server."
 );

specification/postgresql/DBforPostgreSQL.Management/examples/2026-04-01-preview/ServersMajorVersionUpgradePrecheck.json → specification/postgresql/DBforPostgreSQL.Management/examples/2026-04-01-preview/ServersStartMajorVersionUpgradePrecheck.json

@@ -23,6 +23,6 @@
       }
     }
   },
-  "operationId": "Servers_MajorVersionUpgradePrecheck",
-  "title": "Create a major version upgrade precheck validation for a PostgreSQL flexible server."
+  "operationId": "Servers_StartMajorVersionUpgradePrecheck",
+  "title": "Start a major version upgrade precheck validation for a PostgreSQL flexible server."
 }

specification/postgresql/DBforPostgreSQL.Management/models.tsp

@@ -3161,13 +3161,15 @@ model DataEncryption {
   @visibility(Lifecycle.Read)
   geoBackupEncryptionKeyStatus?: EncryptionKeyStatus;
 
+  #suppress "azure-core/no-guid-usage" "To be defined as GUID following recommendation by Azure Resource Manager guidelines."
   @doc("Client id of multi-tenant Microsoft Entra application.")
   @added(Versions.v2026_04_01)
-  primaryFederatedIdentityClientId?: string;
+  primaryFederatedIdentityClientId?: uuid;
 
+  #suppress "azure-core/no-guid-usage" "To be defined as GUID following recommendation by Azure Resource Manager guidelines."
   @doc("Client id of multi-tenant Microsoft Entra application for when it is configured to support geographically redundant backups.")
   @added(Versions.v2026_04_01)
-  geoBackupFederatedIdentityClientId?: string;
+  geoBackupFederatedIdentityClientId?: uuid;
 }
 
 /**
@@ -3950,7 +3952,7 @@ union MaintenanceEventStatus {
 @doc("Properties of a maintenance event resource.")
 @added(Versions.v2026_04_01)
 model MaintenanceEventResourceProperties {
-  @doc("The unique identifier of the maintenance event (e.g. 'op_123456789').")
+  @doc("A service-generated identifier for this maintenance event, assigned by the platform (e.g., 'YL1T-HFG'). The format is not contractual and clients should not attempt to parse or construct this value.")
   @visibility(Lifecycle.Read)
   maintenanceEventId?: string;
 
@@ -4125,7 +4127,7 @@ model MajorVersionUpgradePrecheckResourceProperties {
   createTime?: utcDateTime;
 
   @doc("The status of the precheck validation.")
-  status?: string;
+  status?: MajorVersionUpgradePrecheckStatus;
 
   @doc("The detailed result of the precheck operation.")
   precheckResult?: PrecheckResult;
@@ -4138,24 +4140,42 @@ model MajorVersionUpgradePrecheckResourceProperties {
   policyDetails?: PolicyDetail[];
 }
 
-@doc("Request model for creating a major version upgrade precheck.")
+@doc("Request model for starting a major version upgrade precheck.")
 @added(Versions.v2026_04_01)
-model MajorVersionUpgradePrecheckCreateRequest {
+model StartMajorVersionUpgradePrecheckRequest {
   @doc("The target major version to upgrade to.")
   targetVersion: PostgresMajorVersion;
 }
 
-@doc("Response model for creating a major version upgrade precheck.")
+@doc("Response model for starting a major version upgrade precheck.")
 @added(Versions.v2026_04_01)
-model MajorVersionUpgradePrecheckResponse {
+model StartMajorVersionUpgradePrecheckResponse {
   @doc("The precheck validation ID.")
   name?: string;
 
   @doc("The time when the precheck was created.")
   createTime?: utcDateTime;
 
   @doc("The status of the precheck validation.")
-  status?: string;
+  status?: MajorVersionUpgradePrecheckStatus;
+}
+
+@doc("The status of the major version upgrade precheck.")
+@added(Versions.v2026_04_01)
+union MajorVersionUpgradePrecheckStatus {
+  string,
+
+  @doc("Executing prechecks against the source server")
+  Validating: "Validating",
+
+  @doc("Validation succeeded")
+  Succeeded: "Succeeded",
+
+  @doc("Validation failed")
+  Failed: "Failed",
+
+  @doc("Validation canceled")
+  Canceled: "Canceled",
 }
 
 @doc("Major version upgrade precheck resource for a PostgreSQL flexible server.")

specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2026-04-01-preview/examples/ServersMajorVersionUpgradePrecheck.json → specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2026-04-01-preview/examples/ServersStartMajorVersionUpgradePrecheck.json

@@ -23,6 +23,6 @@
       }
     }
   },
-  "operationId": "Servers_MajorVersionUpgradePrecheck",
-  "title": "Create a major version upgrade precheck validation for a PostgreSQL flexible server."
+  "operationId": "Servers_StartMajorVersionUpgradePrecheck",
+  "title": "Start a major version upgrade precheck validation for a PostgreSQL flexible server."
 }