fix: allow --coalescent to seed --coalescent-opt - #863
Closed
ivan-aksamentov wants to merge 1 commit into
Closed
Conversation
--coalescent-opt declared conflicts_with = "coalescent", so the documented CoalescentMode::Constant { seed } fallback (previous Tc, then the user-supplied --coalescent, then no prior) was unreachable from the CLI. Drop that conflict; the two flags may now be combined and the value seeds the fallback used when the analytic optimization fails.
Member
|
This was intentional, as I think we don't need the fall back. of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix/timetree-coalescent-opt-seed-reachable->rust--coalescent-optdeclaredconflicts_with = "coalescent", so the two flags could not be supplied together. The documentedCoalescentMode::Constant { seed }fallback for a failed analytic optimization (the previous round's--coalescent, then no prior) was therefore unreachable from the CLI, and a unit case even constructed a seeded state the CLI could not produce.This drops that conflict so
--coalescentseeds the optimizer's failure fallback [src].Making the fallback reachable is preferable to deleting the
seedfield: on a degenerate tree, recovery to a user-supplied timescale is desirable, and it is already documented behavior.Work items
conflicts_with = "coalescent"from--coalescent-opt[src]