Repository navigation
fix(kickoff): ask for time before phone collect - #33
Merged
Merged
Conversation
Do not treat "at <restaurant>" as time_text. Book intake asks for party+time when both are missing, and a party-only follow-up asks for time instead of the restaurant number. Co-authored-by: natecl <natecl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
L1 iMessage book intake skipped the time ask when the first text named a restaurant with
at._extract_timetreated everything afteratastime_text, so “can you make a reservation at poke palace for me?” storedpoke palace for me?as the time._decide_bookthen asked only for party size. “2 people” unlocked the restaurant phone ask while time was still missing.Fix
_extract_time/_time_spankeep a clock, am/pm, noon, orat <hour>span.at <restaurant>is not a time._decide_bookstill refuses phone collect and confirm whiletime_textis missing. Invalid pending times are dropped on merge.Proof
7272701288 and at 7:30, and stale invented time.verify-linq-calladdscollect_time(14/14). FEATURE_MAP and feature recipes updated.Nathan LOCK
Collect time before confirm/dial. Do not invent time from unrelated words.