Silence the stray debug print in fd_fdstat_set_rights - #153
Merged
Kronos3 merged 2 commits intoAug 1, 2026
Conversation
wasi_preview1.rs:376 was the only uncommented eprintln! of the 49 in this file, so a guest calling fd_fdstat_set_rights wrote a debug line to the host's stderr. Commented out to match the others.
Kronos3
requested changes
Aug 1, 2026
Contributor
|
Oops I didn't realize all the wasi functions had commented printlns. I'll request @cole-wilson review since he owns this crate. |
CoreMark Benchmark ResultsCurrent Score: 242.072 |
Code Coverage ReportCurrent Coverage: 95.29% |
cole-wilson
approved these changes
Aug 1, 2026
Collaborator
|
Oops, I completely missed that! Thanks for catching it. |
Kronos3
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasi_preview1.rs:376is the only uncommentedeprintln!of the 49 in this file, so a guest callingfd_fdstat_set_rightswrites a debug line to the host's stderr:The same module against
fd_fdstat_getprints nothing.tests/integration.rsasserts only on stdout, which is why this went unnoticed.Commented out to match the other 48 rather than removed.
cargo test -p spacewasistays at 7 passed.AI-assisted (Claude Code) per
AI_POLICY.md.