Repository navigation
Skip pseudo-terminal ioctl test on Nanvix - #913
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The unsupported Nanvix PTY test is explicitly skipped while other ioctl tests remain covered.
Pull request overview
Skips the pseudo-terminal-dependent ioctl test on Nanvix, where PTY pairs are unavailable.
Changes:
- Adds a Nanvix-specific skip.
- Retains the remaining ioctl coverage.
File summaries
| File | Description |
|---|---|
Lib/test/test_ioctl.py |
Skips the unsupported PTY ioctl test on Nanvix. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip
test_ioctl_signed_unsigned_code_paramon Nanvix because it requires a pseudo-terminal pair.Nanvix supports
/dev/ttyand the other ioctl tests pass, but it does not provideopenpty()or legacy/dev/ptyXYdevices. CPython's pure-Pythonptymodule imports successfully and only reports the missing capability whenpty.openpty()is called.Tracks #912.
Testing
test_ioctlpasses against Nanvix v0.24.30 with only the PTY-dependent test skipped.