Repository navigation
Enable _lsprof on Nanvix - #895
Merged
Merged
Conversation
ada-x64
changed the base branch from
nanvix/v3.12.3
to
tests/nskip-058-pathlib-enotdir
August 21, 2026 15:19
There was a problem hiding this comment.
Pull request overview
Enables the built-in _lsprof module on Nanvix and expands its profiling regression coverage.
Changes:
- Enables
_lsprofand regenerates configuration. - Adds four profiling test modules.
- Guards known Nanvix filesystem incompatibilities.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Changes |
|---|---|
Lib/test/test_pathlib.py |
Adds Nanvix skips for affected pathlib tests. |
Lib/test/test_genericpath.py |
Guards the incompatible timestamp test. |
configure.ac |
Enables _lsprof on Nanvix. |
configure |
Regenerates configuration output. |
.nanvix/src/config.py |
Adds profiling modules to the test suite. |
Suppressed comments (1)
.nanvix/src/config.py:112
- These entries are consumed directly by
run_regrtest()(.nanvix/src/test.py:430-455), so they change the regression-suite size..nanvix/NANVIX.md:236-260still says that./z testruns 160 modules in 40 batches and omits the profiling group; those claims become stale with these four additions. Please update the Nanvix status documentation together with this list.
"test_cprofile",
"test_profile",
"test_pstats",
"test_sys_setprofile",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ada-x64
marked this pull request as ready for review
August 24, 2026 14:29
ada-x64
force-pushed
the
feat/297/lsprof
branch
from
August 24, 2026 14:29
f92f95c to
5599ee4
Compare
Base automatically changed from
tests/nskip-058-pathlib-enotdir
to
nanvix/v3.12.3
August 24, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the built-in
_lsprofmodule on Nanvix and add the four profiling modules to the regression suite.Verification
The targeted profiling batch passed 61 tests across
test_cprofile,test_profile,test_pstats, andtest_sys_setprofile, with seven existing subprocess-dependent skips. Verified against the full lifecycle on Nanvixdevat32419d6cc094; all 170 modules and release packaging passed.Closes #297