Skip to content

Enable _lsprof on Nanvix - #895

Merged
ppenna merged 2 commits into
nanvix/v3.12.3from
feat/297/lsprof
Aug 24, 2026
Merged

ppenna merged 2 commits into
nanvix/v3.12.3from
feat/297/lsprof

Conversation

@ada-x64

@ada-x64 ada-x64 commented Aug 21, 2026

Copy link
Copy Markdown

Depends on #894

Summary

Enable the built-in _lsprof module on Nanvix and add the four profiling modules to the regression suite.

Verification

The targeted profiling batch passed 61 tests across test_cprofile, test_profile, test_pstats, and test_sys_setprofile, with seven existing subprocess-dependent skips. Verified against the full lifecycle on Nanvix dev at 32419d6cc094; all 170 modules and release packaging passed.

Closes #297

Copilot AI lite review requested due to automatic review settings August 21, 2026 15:16
@ada-x64
ada-x64 changed the base branch from nanvix/v3.12.3 to tests/nskip-058-pathlib-enotdir August 21, 2026 15:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables the built-in _lsprof module on Nanvix and expands its profiling regression coverage.

Changes:

  • Enables _lsprof and regenerates configuration.
  • Adds four profiling test modules.
  • Guards known Nanvix filesystem incompatibilities.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Changes
Lib/test/test_pathlib.py Adds Nanvix skips for affected pathlib tests.
Lib/test/test_genericpath.py Guards the incompatible timestamp test.
configure.ac Enables _lsprof on Nanvix.
configure Regenerates configuration output.
.nanvix/src/config.py Adds profiling modules to the test suite.
Suppressed comments (1)

.nanvix/src/config.py:112

  • These entries are consumed directly by run_regrtest() (.nanvix/src/test.py:430-455), so they change the regression-suite size. .nanvix/NANVIX.md:236-260 still says that ./z test runs 160 modules in 40 batches and omits the profiling group; those claims become stale with these four additions. Please update the Nanvix status documentation together with this list.
    "test_cprofile",
    "test_profile",
    "test_pstats",
    "test_sys_setprofile",

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ada-x64
ada-x64 marked this pull request as ready for review August 24, 2026 14:29
Base automatically changed from tests/nskip-058-pathlib-enotdir to nanvix/v3.12.3 August 24, 2026 16:46
@ppenna
ppenna merged commit cceac4a into nanvix/v3.12.3 Aug 24, 2026
13 checks passed
@ppenna
ppenna deleted the feat/297/lsprof branch August 24, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable _lsprof stdlib module (cProfile backend)

3 participants