Repository navigation
Re-enable nskip-049 tests - #890
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables the previously skipped Nanvix-related os.utime() “current time” tests in Lib/test/test_os.py by removing the NSKIP049 skip decorators, restoring those test cases to run normally.
Changes:
- Removed
@unittest.skipIf(support.is_nanvix, ...)fortest_utime_current(). - Removed
@unittest.skipIf(support.is_nanvix, ...)fortest_utime_current_old().
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Review details
Suppressed comments (1)
Lib/test/test_os.py:941
- Same as above: this helper ignores its
filenameparameter and hard-codesself.fname. Using the argument matches the pattern used by otherset_time()helpers and avoids surprising callers.
def test_utime_current_old(self):
def set_time(filename):
# Set to the current time in the old explicit way.
os.utime(self.fname, None)
self._test_utime_current(set_time)
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
931
to
935
| def test_utime_current(self): | ||
| def set_time(filename): | ||
| # Set to the current time in the new way | ||
| os.utime(self.fname) | ||
| self._test_utime_current(set_time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables NSKIP049
Closes #529