Repository navigation
Re-enable NSKIP001 - #869
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables pickling-related test coverage on Nanvix by removing the NSKIP001 “pickle corrupt on 32-bit” guards across the CPython test suite, based on the claim that 32-bit Nanvix pickle now works.
Changes:
- Removed
@unittest.skipIf(... is_nanvix ...)decorators for NSKIP001 across manyLib/test/modules to re-run pickling round-trip tests on Nanvix. - Removed inline “neutering” logic that previously bypassed pickle-based assertions (notably in
test_itertools.pyandtest_iter.py). - Restored previously guarded pickle/deprecation-warning test phases that were conditionally skipped on Nanvix.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Lib/test/test_types.py | Re-enables pickle tests for union types and SimpleNamespace on Nanvix. |
| Lib/test/test_tuple.py | Re-enables tuple iterator and reversed-iterator pickle tests. |
| Lib/test/test_statistics.py | Re-enables NormalDist pickling tests. |
| Lib/test/test_slice.py | Re-enables slice pickling tests. |
| Lib/test/test_set.py | Re-enables set/frozenset and iterator pickling tests. |
| Lib/test/test_range.py | Re-enables range and range-iterator pickling tests previously skipped for NSKIP001. |
| Lib/test/test_random.py | Re-enables random.Random pickling tests. |
| Lib/test/test_pathlib.py | Re-enables pathlib pickling tests (previously guarded for proto 0 issues). |
| Lib/test/test_os.py | Re-enables os.stat_result pickling tests. |
| Lib/test/test_ordered_dict.py | Re-enables OrderedDict pickling/iterator pickling tests and removes Nanvix-only bypass. |
| Lib/test/test_operator.py | Re-enables operator-module pickling test classes on Nanvix. |
| Lib/test/test_list.py | Re-enables list iterator/reversed/pickling tests. |
| Lib/test/test_itertools.py | Restores full pickle-based test phases and removes Nanvix pickle bypass logic. |
| Lib/test/test_iter.py | Removes Nanvix pickle-bypass code and re-enables iterator pickling assertions. |
| Lib/test/test_functools.py | Re-enables multiple functools pickling tests (partial, orderings, lru_cache, etc.). |
| Lib/test/test_fractions.py | Re-enables Fraction copy/deepcopy/pickle tests. |
| Lib/test/test_exceptions.py | Re-enables exception attribute/copy/pickle tests. |
| Lib/test/test_dict.py | Re-enables dict iterator pickling tests. |
| Lib/test/test_deque.py | Re-enables deque pickle tests and removes Nanvix-only gating. |
| Lib/test/test_defaultdict.py | Re-enables defaultdict pickling tests. |
| Lib/test/test_decimal.py | Re-enables Decimal/context-related pickling tests. |
| Lib/test/test_collections.py | Re-enables pickling tests for namedtuple descriptors and other collections behaviors. |
| Lib/test/test_builtin.py | Re-enables pickling tests for builtins like filter/map/zip. |
| Lib/test/test_ast.py | Re-enables AST pickling tests. |
| Lib/test/test_array.py | Re-enables array pickling and iterator pickling tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ada-x64
marked this pull request as ready for review
August 3, 2026 15:30
Pickle works on 32-bit Nanvix now. Drop the pickle skips across 24 modules (decorators + inline neutering; neutered files restored to upstream).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469
What
Remove all NSKIP001 pickle skip guards across 24 modules (decorators + inline neutering). The 5 fully-neutered files are restored to upstream v3.12.3, since NSKIP001 was their only nanvix delta.
Why
Pickle works on 32-bit Nanvix now.
Verified the full lifecycle on Linux.