Skip to content

Re-enable NSKIP001 - #869

Merged
ppenna merged 1 commit into
nanvix/v3.12.3from
nskip/001
Aug 5, 2026
Merged

ppenna merged 1 commit into
nanvix/v3.12.3from
nskip/001

Conversation

@ada-x64

@ada-x64 ada-x64 commented Aug 3, 2026

Copy link
Copy Markdown

Closes #469

What

Remove all NSKIP001 pickle skip guards across 24 modules (decorators + inline neutering). The 5 fully-neutered files are restored to upstream v3.12.3, since NSKIP001 was their only nanvix delta.

Why

Pickle works on 32-bit Nanvix now.
Verified the full lifecycle on Linux.

Copilot AI lite review requested due to automatic review settings August 3, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables pickling-related test coverage on Nanvix by removing the NSKIP001 “pickle corrupt on 32-bit” guards across the CPython test suite, based on the claim that 32-bit Nanvix pickle now works.

Changes:

  • Removed @unittest.skipIf(... is_nanvix ...) decorators for NSKIP001 across many Lib/test/ modules to re-run pickling round-trip tests on Nanvix.
  • Removed inline “neutering” logic that previously bypassed pickle-based assertions (notably in test_itertools.py and test_iter.py).
  • Restored previously guarded pickle/deprecation-warning test phases that were conditionally skipped on Nanvix.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Lib/test/test_types.py Re-enables pickle tests for union types and SimpleNamespace on Nanvix.
Lib/test/test_tuple.py Re-enables tuple iterator and reversed-iterator pickle tests.
Lib/test/test_statistics.py Re-enables NormalDist pickling tests.
Lib/test/test_slice.py Re-enables slice pickling tests.
Lib/test/test_set.py Re-enables set/frozenset and iterator pickling tests.
Lib/test/test_range.py Re-enables range and range-iterator pickling tests previously skipped for NSKIP001.
Lib/test/test_random.py Re-enables random.Random pickling tests.
Lib/test/test_pathlib.py Re-enables pathlib pickling tests (previously guarded for proto 0 issues).
Lib/test/test_os.py Re-enables os.stat_result pickling tests.
Lib/test/test_ordered_dict.py Re-enables OrderedDict pickling/iterator pickling tests and removes Nanvix-only bypass.
Lib/test/test_operator.py Re-enables operator-module pickling test classes on Nanvix.
Lib/test/test_list.py Re-enables list iterator/reversed/pickling tests.
Lib/test/test_itertools.py Restores full pickle-based test phases and removes Nanvix pickle bypass logic.
Lib/test/test_iter.py Removes Nanvix pickle-bypass code and re-enables iterator pickling assertions.
Lib/test/test_functools.py Re-enables multiple functools pickling tests (partial, orderings, lru_cache, etc.).
Lib/test/test_fractions.py Re-enables Fraction copy/deepcopy/pickle tests.
Lib/test/test_exceptions.py Re-enables exception attribute/copy/pickle tests.
Lib/test/test_dict.py Re-enables dict iterator pickling tests.
Lib/test/test_deque.py Re-enables deque pickle tests and removes Nanvix-only gating.
Lib/test/test_defaultdict.py Re-enables defaultdict pickling tests.
Lib/test/test_decimal.py Re-enables Decimal/context-related pickling tests.
Lib/test/test_collections.py Re-enables pickling tests for namedtuple descriptors and other collections behaviors.
Lib/test/test_builtin.py Re-enables pickling tests for builtins like filter/map/zip.
Lib/test/test_ast.py Re-enables AST pickling tests.
Lib/test/test_array.py Re-enables array pickling and iterator pickling tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ada-x64
ada-x64 marked this pull request as ready for review August 3, 2026 15:30
Pickle works on 32-bit Nanvix now. Drop the pickle skips across 24 modules (decorators + inline neutering; neutered files restored to upstream).
Copilot AI review requested due to automatic review settings August 5, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 25/25 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@ppenna
ppenna merged commit 971c165 into nanvix/v3.12.3 Aug 5, 2026
13 checks passed
@ppenna
ppenna deleted the nskip/001 branch August 5, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NSKIP001] pickle corrupt on 32-bit

3 participants