Repository navigation
Re-enable NSKIP018 - #866
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables CSimpleQueueTest.test_reentrancy by removing the Nanvix-specific NSKIP018 skip guard in Lib/test/test_queue.py, aligning with the stated fix that circular __del__ cycles are now collected and no longer trigger OOM.
Changes:
- Removed the
@unittest.skipIf(support.is_nanvix, "NSKIP018: ...")decorator fromCSimpleQueueTest.test_reentrancy. - Removed the adjacent in-code
NSKIP018reference comment for that test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ada-x64
marked this pull request as ready for review
August 3, 2026 14:41
Circular __del__ is collected now; no OOM.
There was a problem hiding this comment.
Review details
Suppressed comments (1)
Lib/test/test_queue.py:650
- The module header comment still states that NSKIP018 is an active skip in non-standalone modes, but this PR removes the NSKIP018 skip for CSimpleQueueTest.test_reentrancy. Please update the header comment to avoid misleading future maintainers.
def test_reentrancy(self):
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
What
Remove NSKIP018 guard on test_queue.test_reentrancy. (test_queue stays excluded.)
Why
Circular del is collected now; no OOM.
Verified the full lifecycle on Linux.