Skip to content

Re-enable NSKIP048 - #865

Merged
ppenna merged 1 commit into
nanvix/v3.12.3from
nskip/048
Aug 5, 2026
Merged

ppenna merged 1 commit into
nanvix/v3.12.3from
nskip/048

Conversation

@ada-x64

@ada-x64 ada-x64 commented Jul 31, 2026

Copy link
Copy Markdown

Closes #528

What

Add test_ioctl to the test list; drop the NSKIP048 module skip.

Why

Redundant: fcntl is built; the test self-skips without /dev/tty.
Verified the full lifecycle on Linux.

Copilot AI lite review requested due to automatic review settings July 31, 2026 22:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Nanvix’s CPython test selection to run Lib/test/test_ioctl.py again, and removes the Nanvix-specific module-level skip so the test relies on its existing self-skip behavior (missing fcntl/termios or /dev/tty).

Changes:

  • Removed the Nanvix-only NSKIP048 module skip from Lib/test/test_ioctl.py.
  • Added test_ioctl to the Nanvix SDK image test manifest list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Lib/test/test_ioctl.py Drops Nanvix-only module skip so the test uses its normal import- and /dev/tty-based skipping behavior.
.nanvix/src/config.py Includes test_ioctl in the Nanvix test module list to execute it in the Nanvix test lifecycle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Lib/test/test_ioctl.py
Comment on lines 1 to 2
from test.support import is_nanvix
import unittest
Copilot AI review requested due to automatic review settings August 3, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Lib/test/test_ioctl.py:3

  • is_nanvix is no longer referenced after removing the Nanvix-specific module-level skip, so this import is now unused.
from test.support import is_nanvix
import unittest

@ada-x64
ada-x64 marked this pull request as ready for review August 3, 2026 14:41
Redundant: fcntl is built; the test self-skips without /dev/tty.
Copilot AI review requested due to automatic review settings August 5, 2026 21:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Lib/test/test_ioctl.py:2

  • is_nanvix is no longer used after removing the Nanvix-specific module skip, so this import is now unused and will trigger lint/maintenance noise.
from test.support import is_nanvix
import unittest

@ppenna
ppenna merged commit 297a842 into nanvix/v3.12.3 Aug 5, 2026
13 checks passed
@ppenna
ppenna deleted the nskip/048 branch August 5, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NSKIP048] fcntl/ioctl C extension N/A on Nanvix

3 participants