Repository navigation
Re-enable NSKIP048 - #865
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Nanvix’s CPython test selection to run Lib/test/test_ioctl.py again, and removes the Nanvix-specific module-level skip so the test relies on its existing self-skip behavior (missing fcntl/termios or /dev/tty).
Changes:
- Removed the Nanvix-only
NSKIP048module skip fromLib/test/test_ioctl.py. - Added
test_ioctlto the Nanvix SDK image test manifest list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Lib/test/test_ioctl.py | Drops Nanvix-only module skip so the test uses its normal import- and /dev/tty-based skipping behavior. |
| .nanvix/src/config.py | Includes test_ioctl in the Nanvix test module list to execute it in the Nanvix test lifecycle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from test.support import is_nanvix | ||
| import unittest |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Lib/test/test_ioctl.py:3
is_nanvixis no longer referenced after removing the Nanvix-specific module-level skip, so this import is now unused.
from test.support import is_nanvix
import unittest
Redundant: fcntl is built; the test self-skips without /dev/tty.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Lib/test/test_ioctl.py:2
is_nanvixis no longer used after removing the Nanvix-specific module skip, so this import is now unused and will trigger lint/maintenance noise.
from test.support import is_nanvix
import unittest
Closes #528
What
Add test_ioctl to the test list; drop the NSKIP048 module skip.
Why
Redundant: fcntl is built; the test self-skips without /dev/tty.
Verified the full lifecycle on Linux.