Repository navigation
Re-enable NSKIP047 - #864
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to re-enable the dbm-related tests for Nanvix by removing the NSKIP047 module-level skips and adding test_dbm, test_dbm_gnu, and test_dbm_ndbm to the Nanvix test manifest list.
Changes:
- Removed the Nanvix-specific
NSKIP047module skips fromtest_dbm,test_dbm_gnu, andtest_dbm_ndbm. - Added
test_dbm,test_dbm_gnu, andtest_dbm_ndbmto the.nanvixSDK image test list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Lib/test/test_dbm.py | Removes Nanvix module skip that previously prevented running dbm backend tests on Nanvix. |
| Lib/test/test_dbm_gnu.py | Removes Nanvix module skip and relies on import_helper.import_module() self-skip behavior. |
| Lib/test/test_dbm_ndbm.py | Removes Nanvix module skip and relies on import_helper.import_module() self-skip behavior. |
| .nanvix/src/config.py | Adds dbm-related tests to the Nanvix SDK image test manifest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
5
| from test.support import is_nanvix | ||
| import unittest | ||
| if is_nanvix: | ||
| raise unittest.SkipTest("NSKIP047: _dbm/_gdbm/_ndbm C backends N/A on Nanvix (configure.ac:7268)") | ||
|
|
Comment on lines
1
to
3
| from test.support import is_nanvix | ||
| import unittest | ||
| if is_nanvix: | ||
| raise unittest.SkipTest("NSKIP047: _dbm/_gdbm/_ndbm C backends N/A on Nanvix (configure.ac:7268)") # detail: only _gdbm needed for this module | ||
|
|
Comment on lines
1
to
3
| from test.support import is_nanvix | ||
| import unittest | ||
| if is_nanvix: | ||
| raise unittest.SkipTest("NSKIP047: _dbm/_gdbm/_ndbm C backends N/A on Nanvix (configure.ac:7268)") # detail: only _dbm needed for this module | ||
|
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (3)
Lib/test/test_dbm.py:6
- Removing the Nanvix module-level skip makes this test run with the fallback pure-Python backend (dbm.dumb) when no C dbm backends are built. On Nanvix, dbm.dumb._commit() uses os.rename() (Lib/dbm/dumb.py:126), and Nanvix already skips dbm.dumb tests for NSKIP021 because rename() hangs the kernel. Without a guard here, running test_dbm on Nanvix can hang rather than cleanly skip.
from test.support import is_nanvix
import unittest
import dbm
Lib/test/test_dbm_ndbm.py:2
is_nanvixis now unused after removing the Nanvix-specific skip. Keeping it adds dead imports and makes it easier to miss real platform guards.
from test.support import is_nanvix
import unittest
Lib/test/test_dbm_gnu.py:2
is_nanvixis now unused after removing the Nanvix-specific skip. Keeping it adds dead imports and makes it easier to miss real platform guards.
from test.support import is_nanvix
import unittest
ada-x64
marked this pull request as ready for review
August 3, 2026 14:41
Redundant: the tests self-skip when the C backends are absent. (Backends still unbuilt.)
There was a problem hiding this comment.
Review details
Suppressed comments (3)
Lib/test/test_dbm_gnu.py:3
is_nanvixis now unused after removing the Nanvix-only SkipTest, so this import should be dropped.
from test.support import is_nanvix
import unittest
Lib/test/test_dbm_ndbm.py:3
is_nanvixis now unused after removing the Nanvix-only SkipTest, so this import should be dropped.
from test.support import is_nanvix
import unittest
Lib/test/test_dbm.py:5
is_nanvixis now unused after removing the Nanvix-only SkipTest, so this import should be dropped to avoid dead code.
from test.support import is_nanvix
import unittest
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #527
What
Add test_dbm / test_dbm_gnu / test_dbm_ndbm to the test list; drop the NSKIP047 module skips.
Why
Redundant: the tests self-skip when the C backends are absent. (Backends still unbuilt.)
Verified the full lifecycle on Linux.