Repository navigation
Re-enable NSKIP038 - #854
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables the test_posix_fadvise_errno test on Nanvix by removing the Nanvix-specific skip guard, aligning the test suite with the reported fix that posix_fadvise now returns the correct errno.
Changes:
- Removed the
NSKIP038@skipIf(support.is_nanvix, ...)decorator fromtest_posix_fadvise_errno. - Dropped the now-obsolete inline
NSKIP038comment referencing issue #518.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ada-x64
marked this pull request as ready for review
August 3, 2026 14:42
posix_fadvise returns the correct errno now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #518
What
Remove NSKIP038 guard on test_posix.test_posix_fadvise_errno.
Why
posix_fadvise returns the correct errno now.
Verified the full lifecycle on Linux.