Draft
Conversation
Contributor
Author
|
(Oh, and I forgot to mention, it obviously compiles and runs and I quickly checked that the output make sense with ncview, but haven't taken the time to make sure they all add up) |
Member
|
We should reconsider the names of some of the variables. |
einola
requested changes
May 16, 2023
Member
einola
left a comment
einola
left a comment
There was a problem hiding this comment.
It looks good, except for one suspicious line delete, which I'd like you to look at.
Is it otherwise ready? It's still marked as a draft.
| if ( M_h_young[i] < h_young_min*M_conc_young[i] ) | ||
| { | ||
| M_conc_young[i] = M_h_young[i]/h_young_min; | ||
| young_ice_growth =M_conc_young[i] - old_conc_young ; |
Member
There was a problem hiding this comment.
Why do you remove this line? It seems young_ice_growth is needed for redistributeThermoFSD.
einola
approved these changes
Jul 16, 2023
Conflicts: model/finiteelement.cpp
Member
|
Ping @docguibou |
Contributor
Author
|
Yes Yes I know… Still making me crazy, even though it’s really close to balance now.
Guillaume Boutin
forsker | Researcher
***@***.*** |
Stiftelsen Nansen Senter for Miljø og Fjernmåling
Nansen Environmental and Remote Sensing Center
Jahnebakken 3 | N-5007 Bergen | Norway
***@***.*** | nersc.no<https://nersc.no> | +47 55 20 58 00
[cid:logo_de1c6baf-5da6-4f53-b1e5-34827df1144c.jpg]
Konfidensialitet. Informasjonen i denne e-posten er utelukkende ment for bruk av adressaten(e),
og kan inneholde konfidensiell informasjon som ikke kan deles uten avsenders skriftlige samtykke.
Notice of confidentiality. The information contained in this e-mail is intended solely for the use of
the addressee(s) and may contain confidential or legally privileged information.
From: Einar Örn Ólason ***@***.***>
Date: Thursday, 14 December 2023 at 08:44
To: nansencenter/nextsim ***@***.***>
Cc: Guillaume Boutin ***@***.***>, Mention ***@***.***>
Subject: Re: [nansencenter/nextsim] Issue623 adding new budget terms (PR #625)
Ping @docguibou<https://github.com/docguibou>
—
Reply to this email directly, view it on GitHub<#625 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5CRNFJWENRJ2SCVV5667LYJKU7JAVCNFSM6AAAAAASW4QOYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVGMZTOMZRGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
No worries! :D I just didn't know what the situation was. |
Member
|
And there's still the question about removing |
added 2 commits
December 15, 2023 15:55
…nly if age.equal_ridging=false, which is the default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the addition 7 new source terms to fully close the ice area & volume budget as requested by Clemens.
I have tried to figure out what was needed (initially we agreed on 5) but it seems if you want to understand what contributes to what completely, you need 7. It may be that some of these 7 may be inferred from other terms or that the separation of each term could be smarter, do not hesitate to come with your suggestions, but I thought by adding them all then it is easy to check whether what we think is equivalent really works or not.
The source terms are:
dci: (old) sea ice area change rate due to thermo [/day]
dci_young: young sea ice area change rate due to thermo [/day]
dci_young2old: young sea ice area transferred to 'old' due to thermo [/day]
dvi_young2old: young sea ice volume transferred to 'old' due to thermo [m/day] (Could be computed from dci_young2old ??)
dci_ridge: (old) sea ice area change rate due to dynamics (ridging) [/day]
dci_ridge_young: young sea ice area change rate due to dynamics (ridging) [/day]
dvi_ridge_young: young sea ice volume change rate due to dynamics (ridging) [m/day] (transferred to 'old')