fix(terraform): resolve account_id from AWS_ACCOUNT_ID env#31
Merged
Conversation
The per-environment env.hcl files set account_id, which root.hcl embeds in the remote-state bucket name (eks-agent-platform-tfstate-<account_id>-<region>). terragrunt evaluates that at parse time, before any AWS API is reachable, so the value can't arrive as a TF_VAR_ (those reach the leaf module, not the backend config). It now resolves from the AWS_ACCOUNT_ID environment variable via get_env, so no AWS account id lives in git — this is a public repo. The orchestrator (portal's per-environment workspace) sets AWS_ACCOUNT_ID; a manual leaf run exports it in the shell, the same way the other identifiers arrive as TF_VAR_*. Applied across dev, staging, and production for a uniform pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-environment
env.hclfiles setaccount_id, whichroot.hclembeds in the remote-state bucket name (eks-agent-platform-tfstate-<account_id>-<region>). terragrunt evaluates that at parse time, before any AWS API is reachable, so the value can't arrive as aTF_VAR_(those reach the leaf, not the backend config).It now resolves from the
AWS_ACCOUNT_IDenvironment variable viaget_env, so no AWS account id lives in git — this is a public repo. The orchestrator (portal's per-environment workspace) setsAWS_ACCOUNT_ID; a manual leaf run exports it in the shell, the same way the other identifiers arrive asTF_VAR_*. Applied across dev, staging, and production for a uniform pattern (production previously carried a real id; dev/staging wereREPLACE_WITH_*placeholders).Validated:
terragrunt hcl format --checkclean on all three;terragrunt renderparses the config and builds the bucket name fromAWS_ACCOUNT_ID(fails only later at the AWS-credential stage, confirmingget_envresolves at parse time).