Repository navigation
Add code-architect template (engineering/) - #24
Merged
Merged
Conversation
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
August 29, 2026 14:09
73e8824 to
4f728eb
Compare
zvi-fried
marked this pull request as ready for review
August 29, 2026 14:09
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
5 times, most recently
from
August 29, 2026 20:00
a1fac22 to
b0c6b3a
Compare
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
August 30, 2026 21:35
0f01470 to
6708c7b
Compare
amit-shafnir
previously approved these changes
Aug 30, 2026
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
August 30, 2026 21:49
6708c7b to
2749f1c
Compare
amit-shafnir
previously approved these changes
Aug 30, 2026
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
August 30, 2026 21:52
2749f1c to
544d2c1
Compare
amit-shafnir
previously approved these changes
Aug 30, 2026
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
8 times, most recently
from
September 1, 2026 13:16
65dff25 to
a4f395b
Compare
amit-shafnir
previously approved these changes
Sep 3, 2026
Review feedback: the shared expert execution section was seven paragraphs of up to ~940 words each, with a dozen rules per paragraph. Break every step into a headed section with one rule per bullet, group the Librarian step into relay rules and coordinator validation rules, and group verification into books, Tech lead sources, and production proof. Bullet the report rules and fix the dangling colon in the contracts intro. No rule was added, removed, or changed; wording is preserved. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
NanoClaw copies each skill out of the plugin into the agent's skills overlay, so `../../references/` never resolves there; the library lives at `plugins/code-architect/references/` under the workspace. Name that path first in both skills, keep the in-place path for harnesses that load the plugin where it sits, and make every library reference relative to the library instead of to the skill file. Correct the README's portability claim to match. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The fast path asked for exactly two books with no way to produce them: the request has no count field, the Librarian returns two to four, and the coordinator's rebuild never trims. Drop the feature from the review skill, the persona, the expert index, and the review evals. Panel size is still decided by evidence in the scope, so a small review seats a small panel through the normal rules. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Give the book flow a replacement path the schemas can express: a request carries request_kind and, on replacement, the excluded_books it has rejected; the Librarian answers a replacement with exactly one book; the coordinator merges, re-ids, and forwards the full list, and stops when an expert would fall below two books. Carry selection_rationale through the rebuilt list so the forwarded record validates. Echo the request's role under the same name. Make justification required for every book-guided seat and absent for the standing Tech lead. Require a non-empty published_or_observed on source notes and source checks. Describe expert isolation as fresh, non-forked subagents instead of a platform option that does not exist, and align planning's language-expert rule with the persona. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Rename the workflow title to match the template, connect book selection to every book-guided expert in the diagram instead of only the language expert, note in the contracts table that book requests reach the Librarian through the coordinator, normalize the Change management lens name, drop the duplicated maintainer prompt from both eval files, and move the README image to the repo-level assets directory at a smaller size so it is no longer copied into every stamped agent group. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
September 4, 2026 05:54
a4f395b to
3cefbe5
Compare
The always-loaded instructions were one block of prose. Group the same rules under Routing, Shared library, Panel, Tech lead, Books, Verification and synthesis, Production proof, and Delivery, one rule per bullet. No rule was added, removed, or changed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
September 7, 2026 05:47
4d49942 to
39eb3cb
Compare
Give every rule a single home. The persona keeps routing and delivery; workflow.md owns the shared "Scope and panel" rules and the report skeleton; each skill keeps only its own scope inputs, contract names, and output sections; the Tech lead, Librarian, and expert-protocol files are the only statements of their own rules. The shared library moves into the architecture-review skill, where sibling-skill relative paths already resolve on NanoClaw, so the path-explanation paragraphs and the container absolute path leave the portable files. The two expert contracts pull book_practices and standards_conformance from shared-definitions.json through $ref. The verification record merges its two per-book arrays and lets source_checks record any expert's cited URL. Book identity is verified once, in step 3, and step 7 no longer repeats the lookup; the Tech lead and Librarian branches run concurrently. The expert index defines the role id for every lens. When the scope contains agent skills, plugins, MCP servers or clients, or agent instruction files, the AI architect checks each against the standard that governs it, listed with its URL in the AI lens definition: the Model Context Protocol specification, the Agent Plugins standard, the Agent Skills format and Claude's Agent Skills docs, the AGENTS.md convention, and Claude's CLAUDE.md guidance. The standards_conformance field is required when the role is ai; the coordinator confirms each cited clause in step 7 and both reports carry a standards conformance section. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zvi-fried
force-pushed
the
add-architects-roundtable-template
branch
from
September 7, 2026 08:32
39eb3cb to
dcd7cd5
Compare
amit-shafnir
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this template does
Adds The Code Architect, a read-only architecture planning and review template at
engineering/code-architect/.One self-contained
architectureskill selects planning or review mode. Each mode supplies its scope, expert output contract, checks, and report sections. Both use the same workflow, expert definitions, and contracts inside the skill'sreferences/folder.The coordinator seats a small expert panel based on the problem. A shared Librarian selects exact book editions; experts apply their own knowledge of those books and trace practices to architecture evidence. A standing Tech lead researches current sources. The coordinator verifies the evidence and writes the final report, including strengths, risks, tradeoffs, and any missing production proof. The AI expert also checks relevant skills, plugins, MCP interfaces, and instruction files against their published standards.
Structure and contracts
contracts/expert-planning-proposal.json; review usescontracts/expert-review-analysis.json.contracts/tech-lead-current-brief.jsonin both modes.references/directory. The coordinator provides the resolved contract to each isolated expert.$reflinks. Expert interface rules live once inagents/expert-protocol.md.Requires a host with fresh isolated subagents and web search. No MCP servers, scheduled tasks, credentials, paid service integrations, or bundled books. Implementation requires a separate user request.
Validation
node scripts/check-templates.mjs: all 6 templates pass.node scripts/build-index.mjs: no index drift.claude plugin validate engineering/code-architect: passed.npx skills add . --list: the singlearchitectureskill is valid and discoverable.