Repository navigation
fix: release the key lease when a pooled call is cancelled - #1369
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pooled provider call cancelled mid-flight (the server's 45 s
EMBED_CALL_DEADLINE_S, a shutdown) raisesCancelledError, which is aBaseException.KeyPool.arunreleases the lease only onException, so the credential stayed leased forLEASE_SECONDS(60 s) and the next call failed withpool exhausted (... leased=1)even though the provider was healthy.The attempt wrapper now reports a non-Exception escape as
report_failure(credential, None):classify_status(None)isfatal, which takes hull's release path and never blames, cools down or disables the key.Regression test
test_cancelled_call_releases_the_only_leasecancels a single-key call withwait_forand asserts the next call is served. It fails before the change (leased=1) and passes after.The root fix belongs in hull's
KeyPool.arun; this wrapper can be dropped once a hull release carries it.