fix: initialize photos and reviews variables to fix NameError #589#594
Open
Thon122 wants to merge 1 commit into
Open
fix: initialize photos and reviews variables to fix NameError #589#594Thon122 wants to merge 1 commit into
Thon122 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a NameError that occurs when using the --json flag in the email module. The variables photos and reviews were being referenced in the json_results dictionary construction without being initialized in the scope of the hunt function.
Changes
Initialized photos and reviews to None within the Maps data section of ghunt/modules/email.py.
Ensures the JSON output logic has access to these variables even if they are not populated by the gmaps helper.
Fixes
Closes #589
Testing
Verified that python ghunt.py email [target] --json no longer crashes with a NameError.
Confirmed that the resulting JSON file correctly includes null values for photos and reviews when data is unavailable