Fix invalid datetime UTC offset error in some pacific timezone#2
Merged
Fix invalid datetime UTC offset error in some pacific timezone#2
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts WMI CIM datetime parsing to support Pacific timezones with UTC offsets beyond +12:00 (e.g., UTC+14:00), preventing “invalid datetime UTC offset” errors when parsing valid WMI timestamps.
Changes:
- Expand accepted positive UTC offset range from +720 to +840 minutes in
parseDateTime. - Add a unit test covering parsing of a
+840(UTC+14) offset datetime string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wmi.go |
Updates parseDateTime to allow UTC offsets up to +840 minutes (UTC+14). |
wmi_test.go |
Adds a regression test validating parsing and localization behavior for a +840 offset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks! I’m currently away on vacation and will be back in two weeks. I’ll take a look then. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible to have offsets greater than 720 in some countries. Currently, the offset for New Zealand is 780, and it seems that the offset for the Line Islands is 840.