Skip to content

refactor: resolve documented architecture and quality gaps - #36

Merged
mustafayigitt merged 56 commits into
mainfrom
refactor/resolve-risks-and-gaps
Sep 29, 2026
Merged

mustafayigitt merged 56 commits into
mainfrom
refactor/resolve-risks-and-gaps

Conversation

@mustafayigitt

@mustafayigitt mustafayigitt commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Implements the actionable architecture and quality items from wiki/07-risks-and-gaps.md.

Implemented

  • process-death navigation restoration using stable route strings
  • fail-fast unknown-route and duplicate-restorer behavior
  • route restoration for existing and newly scaffolded features
  • theme/navigation contract separation and removal of the navigation → data dependency
  • Retrofit migration from Gson to kotlinx.serialization
  • explicit coroutine-cancellation propagation coverage
  • exact-count data-strategy projection rewrites and build-logic tests
  • network-free kotlinx.serialization converter cleanup/residue validation
  • centralized CI secret bootstrap
  • strict MkDocs validation
  • Jacoco XML/HTML artifact generation
  • build-logic tests in CI
  • API 35 benchmark workflow with retry handling
  • fast, bounded pull-request CI with emulator benchmarking moved to a separate manual/scheduled workflow
  • updated GitHub wiki risk, navigation, network, topology, and CI documentation

Scope boundary

offline-first remains an explicit topology selecting network/auth plus Room. Synchronization, conflict resolution, retry, cache, and reconciliation policy are intentionally product-specific and are not generated.

Validation

All required pull-request checks pass on the final head:

  • Lint (ktlint + detekt + docs)
  • Unit Tests + Coverage
  • Assemble Debug + Release
  • Plug-out (optional modules removed)
  • Template Smoke (remote)

The local, minimal, and offline-first projections also passed before the full matrix was moved out of the blocking PR path. Emulator benchmark instrumentation remains available through the dedicated manual/scheduled Benchmark workflow.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic: the ktlint plugin coordinate was corrected and the current CI run validates the final build.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic. Temporary diagnostic workflows have been removed.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic: the reported navigation test formatting was fixed.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic: NetworkModule formatting was fixed.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic. See the current CI checks for final validation.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic: the Dagger Hilt catalog alias was restored.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic: NetworkModule formatting was fixed.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Superseded diagnostic. Temporary diagnostic workflows have been removed.

@github-actions

Copy link
Copy Markdown

Final gate diagnostics

  • lint status: 1
  • local projection status: 1
  • offline-first projection status: 1

Lint tail

> Task :core:navigation:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :core:navigation:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :core:navigation:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :core:navigation:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :core:navigation:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :core:database:ktlintMainSourceSetCheck
> Task :core:database:ktlintCheck
> Task :core:network:loadKtlintReporters FROM-CACHE
> Task :core:network:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :core:network:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :core:network:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :core:network:ktlintAndroidTestSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverDebugSourceSet NO-SOURCE
> Task :core:network:ktlintDebugSourceSetCheck SKIPPED
> Task :core:google-play:runKtlintCheckOverMainSourceSet
> Task :core:network:runKtlintCheckOverKotlinScripts
> Task :core:google-play:ktlintMainSourceSetCheck
> Task :core:google-play:ktlintCheck
> Task :core:network:ktlintKotlinScriptCheck
> Task :core:network:runKtlintCheckOverReleaseSourceSet NO-SOURCE
> Task :core:network:ktlintReleaseSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverTestDebugSourceSet NO-SOURCE
> Task :core:network:ktlintTestDebugSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverTestFixturesDebugSourceSet NO-SOURCE
> Task :core:network:ktlintTestFixturesDebugSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverTestFixturesReleaseSourceSet NO-SOURCE
> Task :core:network:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :core:network:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :core:network:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :core:network:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :core:navigation:runKtlintCheckOverTestSourceSet
> Task :core:navigation:runKtlintCheckOverMainSourceSet
> Task :core:navigation:ktlintTestSourceSetCheck
> Task :core:permission:loadKtlintReporters FROM-CACHE
> Task :core:permission:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :core:permission:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :core:permission:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :core:permission:ktlintAndroidTestSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverDebugSourceSet NO-SOURCE
> Task :core:navigation:ktlintMainSourceSetCheck
> Task :core:permission:ktlintDebugSourceSetCheck SKIPPED
> Task :core:navigation:ktlintCheck
> Task :core:secrets:loadKtlintReporters FROM-CACHE
> Task :core:permission:runKtlintCheckOverKotlinScripts
> Task :core:network:runKtlintCheckOverTestSourceSet
> Task :core:network:runKtlintCheckOverMainSourceSet
> Task :core:permission:runKtlintCheckOverReleaseSourceSet NO-SOURCE
> Task :core:permission:ktlintReleaseSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverTestDebugSourceSet NO-SOURCE
> Task :core:permission:ktlintKotlinScriptCheck
> Task :core:permission:ktlintTestDebugSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverTestFixturesDebugSourceSet NO-SOURCE
> Task :core:permission:ktlintTestFixturesDebugSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverTestFixturesReleaseSourceSet NO-SOURCE
> Task :core:permission:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :core:permission:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :core:permission:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :core:permission:runKtlintCheckOverTestSourceSet NO-SOURCE
> Task :core:permission:ktlintTestSourceSetCheck SKIPPED
> Task :core:secrets:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :core:secrets:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :core:secrets:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :core:secrets:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :core:secrets:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :core:secrets:ktlintAndroidTestSourceSetCheck SKIPPED
> Task :core:secrets:runKtlintCheckOverDebugSourceSet NO-SOURCE
> Task :core:secrets:ktlintDebugSourceSetCheck SKIPPED
> Task :core:network:ktlintTestSourceSetCheck
> Task :core:security:loadKtlintReporters FROM-CACHE

> Task :core:network:ktlintMainSourceSetCheck FAILED
/home/runner/work/ComposeTemplate/ComposeTemplate/core/network/src/main/java/com/ytapps/composetemplate/core/network/di/NetworkModule.kt:3:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/home/runner/work/ComposeTemplate/ComposeTemplate/core/network/src/main/java/com/ytapps/composetemplate/core/network/di/NetworkModule.kt:28:9 No whitespace expected between opening parenthesis and first parameter name
/home/runner/work/ComposeTemplate/ComposeTemplate/core/network/src/main/java/com/ytapps/composetemplate/core/network/di/NetworkModule.kt:28:69 No whitespace expected between last parameter and closing parenthesis
/home/runner/work/ComposeTemplate/ComposeTemplate/core/network/src/main/java/com/ytapps/composetemplate/core/network/di/NetworkModule.kt:86:9 No whitespace expected between opening parenthesis and first parameter name
/home/runner/work/ComposeTemplate/ComposeTemplate/core/network/src/main/java/com/ytapps/composetemplate/core/network/di/NetworkModule.kt:86:46 No whitespace expected between last parameter and closing parenthesis

> Task :core:permission:runKtlintCheckOverMainSourceSet
> Task :core:secrets:runKtlintCheckOverKotlinScripts
> Task :core:security:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :core:security:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :core:security:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :core:security:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :core:security:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :core:permission:ktlintMainSourceSetCheck
> Task :core:secrets:runKtlintCheckOverMainSourceSet
gradle/actions: Writing build results to /home/runner/work/_temp/.gradle-actions/build-results/__run_2-1790546868150.json

[Incubating] Problems report is available at: file:///home/runner/work/ComposeTemplate/ComposeTemplate/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':core:network:ktlintMainSourceSetCheck' (registered by plugin 'org.jlleitschuh.gradle.ktlint').
> A failure occurred while executing org.jlleitschuh.gradle.ktlint.worker.ConsoleReportWorkAction
   > KtLint found code style violations. Please see the following reports:
     - /home/runner/work/ComposeTemplate/ComposeTemplate/core/network/build/reports/ktlint/ktlintMainSourceSetCheck/ktlintMainSourceSetCheck.txt
     - /home/runner/work/ComposeTemplate/ComposeTemplate/core/network/build/reports/ktlint/ktlintMainSourceSetCheck/ktlintMainSourceSetCheck.xml

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.5.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 1m 39s
64 actionable tasks: 56 executed, 8 from cache

Local projection tail


�[34m╔════════════════════════════════════════════════════════════╗�[0m
�[34m║         Project Initialization Started                     ║�[0m
�[34m╚════════════════════════════════════════════════════════════╝�[0m

�[34mℹ�[0m Copying consumer project files...
�[34mℹ�[0m Updating package names and references...
�[34mℹ�[0m Restructuring directory hierarchy...
�[34mℹ�[0m Removing template-only setup and documentation...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:create-new-app' (registered by plugin 'composetemplate.create.new.app').
> Generated project contains template-only residue:
   - .github/workflows/ci.yml contains 'mkdocs.yml'
   - .github/workflows/diagnostic.yml contains 'create-new-app'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s

Offline-first projection tail


�[34m╔════════════════════════════════════════════════════════════╗�[0m
�[34m║         Project Initialization Started                     ║�[0m
�[34m╚════════════════════════════════════════════════════════════╝�[0m

�[34mℹ�[0m Copying consumer project files...
�[34mℹ�[0m Updating package names and references...
�[34mℹ�[0m Restructuring directory hierarchy...
�[34mℹ�[0m Removing template-only setup and documentation...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:create-new-app' (registered by plugin 'composetemplate.create.new.app').
> Generated project contains template-only residue:
   - .github/workflows/ci.yml contains 'mkdocs.yml'
   - .github/workflows/diagnostic.yml contains 'create-new-app'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s

@mustafayigitt
mustafayigitt marked this pull request as ready for review September 27, 2026 22:27
@github-actions

Copy link
Copy Markdown

Remaining gate diagnostics

lint=1 minimal=1 offline=1

lint

> Task :feature:auth:domain:ktlintReleaseSourceSetCheck SKIPPED
> Task :feature:auth:domain:runKtlintCheckOverTestDebugSourceSet NO-SOURCE
> Task :feature:auth:domain:ktlintTestDebugSourceSetCheck SKIPPED
> Task :feature:auth:domain:runKtlintCheckOverTestFixturesDebugSourceSet NO-SOURCE
> Task :feature:auth:domain:ktlintTestFixturesDebugSourceSetCheck SKIPPED
> Task :feature:auth:domain:runKtlintCheckOverTestFixturesReleaseSourceSet NO-SOURCE
> Task :feature:auth:domain:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :feature:auth:domain:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :feature:auth:domain:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :feature:auth:domain:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :feature:auth:domain:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :feature:auth:data:ktlintMainSourceSetCheck
> Task :feature:auth:data:ktlintCheck
> Task :feature:auth:navigation:loadKtlintReporters FROM-CACHE
> Task :feature:auth:navigation:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintAndroidTestSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverDebugSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintDebugSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverKotlinScripts
> Task :feature:auth:domain:runKtlintCheckOverMainSourceSet
> Task :feature:auth:domain:runKtlintCheckOverTestSourceSet
> Task :feature:auth:navigation:ktlintKotlinScriptCheck
> Task :feature:auth:domain:ktlintMainSourceSetCheck
> Task :feature:auth:navigation:runKtlintCheckOverReleaseSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintReleaseSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverTestDebugSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintTestDebugSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverTestFixturesDebugSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintTestFixturesDebugSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverTestFixturesReleaseSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverTestSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintTestSourceSetCheck SKIPPED
> Task :feature:auth:navigation:runKtlintCheckOverMainSourceSet
> Task :feature:auth:domain:ktlintTestSourceSetCheck
> Task :feature:auth:domain:ktlintCheck
> Task :feature:auth:presentation:loadKtlintReporters FROM-CACHE
> Task :feature:auth:presentation:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintAndroidTestSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverDebugSourceSet NO-SOURCE
> Task :feature:detail:data:loadKtlintReporters FROM-CACHE
> Task :feature:auth:presentation:ktlintDebugSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintAndroidTestReleaseSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverAndroidTestSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintAndroidTestSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverDebugSourceSet NO-SOURCE
> Task :feature:auth:navigation:ktlintMainSourceSetCheck
> Task :feature:auth:navigation:ktlintCheck
> Task :feature:auth:presentation:runKtlintCheckOverReleaseSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintReleaseSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverTestDebugSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintTestDebugSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverTestFixturesDebugSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintTestFixturesDebugSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverTestFixturesReleaseSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :feature:auth:presentation:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :feature:auth:presentation:runKtlintCheckOverKotlinScripts
> Task :feature:detail:data:ktlintDebugSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverKotlinScripts
> Task :feature:auth:presentation:runKtlintCheckOverTestSourceSet
> Task :feature:auth:presentation:ktlintKotlinScriptCheck
> Task :feature:auth:presentation:runKtlintCheckOverMainSourceSet
> Task :feature:auth:presentation:ktlintTestSourceSetCheck
> Task :feature:detail:data:runKtlintCheckOverMainSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintMainSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverReleaseSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintReleaseSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverTestDebugSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintTestDebugSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverTestFixturesDebugSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintTestFixturesDebugSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverTestFixturesReleaseSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintTestFixturesReleaseSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverTestFixturesSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintKotlinScriptCheck
> Task :feature:detail:data:ktlintTestFixturesSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverTestReleaseSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintTestReleaseSourceSetCheck SKIPPED
> Task :feature:detail:data:runKtlintCheckOverTestSourceSet NO-SOURCE
> Task :feature:detail:data:ktlintTestSourceSetCheck SKIPPED
> Task :feature:detail:data:ktlintCheck
> Task :feature:detail:domain:loadKtlintReporters FROM-CACHE
> Task :feature:detail:navigation:loadKtlintReporters FROM-CACHE

> Task :feature:auth:presentation:ktlintMainSourceSetCheck FAILED
/home/runner/work/ComposeTemplate/ComposeTemplate/feature/auth/presentation/src/main/java/com/ytapps/composetemplate/feature/auth/presentation/AuthScreenProvider.kt:13:69 First line of body expression fits on same line as function signature

> Task :feature:detail:navigation:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :feature:detail:navigation:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :feature:detail:domain:runKtlintCheckOverAndroidTestDebugSourceSet NO-SOURCE
> Task :feature:detail:domain:ktlintAndroidTestDebugSourceSetCheck SKIPPED
> Task :feature:detail:domain:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :feature:detail:navigation:runKtlintCheckOverAndroidTestReleaseSourceSet NO-SOURCE
> Task :core:ui:runKtlintCheckOverMainSourceSet
gradle/actions: Writing build results to /home/runner/work/_temp/.gradle-actions/build-results/__run_2-1790548806876.json

[Incubating] Problems report is available at: file:///home/runner/work/ComposeTemplate/ComposeTemplate/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':feature:auth:presentation:ktlintMainSourceSetCheck' (registered by plugin 'org.jlleitschuh.gradle.ktlint').
> A failure occurred while executing org.jlleitschuh.gradle.ktlint.worker.ConsoleReportWorkAction
   > KtLint found code style violations. Please see the following reports:
     - /home/runner/work/ComposeTemplate/ComposeTemplate/feature/auth/presentation/build/reports/ktlint/ktlintMainSourceSetCheck/ktlintMainSourceSetCheck.txt
     - /home/runner/work/ComposeTemplate/ComposeTemplate/feature/auth/presentation/build/reports/ktlint/ktlintMainSourceSetCheck/ktlintMainSourceSetCheck.xml

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.5.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 1m 41s
105 actionable tasks: 89 executed, 16 from cache

minimal


�[34m╔════════════════════════════════════════════════════════════╗�[0m
�[34m║         Project Initialization Started                     ║�[0m
�[34m╚════════════════════════════════════════════════════════════╝�[0m

�[34mℹ�[0m Copying consumer project files...
�[34mℹ�[0m Updating package names and references...
�[34mℹ�[0m Restructuring directory hierarchy...
�[34mℹ�[0m Removing template-only setup and documentation...

�[32m✔ Project created successfully!�[0m
�[33mNext steps:�[0m
  1. cd ../DiagMinimal
  2. git init && git add . && git commit -m "Initial commit"
  3. Open with Android Studio & Sync Gradle

Happy Coding! 🚀


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:create-new-app' (registered by plugin 'composetemplate.create.new.app').
> Generated minimal project contains data-strategy residue:
   - build-logic/convention/src/test/kotlin/com/example/diagminimal/convention/DataStrategyProjectorTest.kt contains 'DataStrategyProjector'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s

offline


�[34m╔════════════════════════════════════════════════════════════╗�[0m
�[34m║         Project Initialization Started                     ║�[0m
�[34m╚════════════════════════════════════════════════════════════╝�[0m

�[34mℹ�[0m Copying consumer project files...
�[34mℹ�[0m Updating package names and references...
�[34mℹ�[0m Restructuring directory hierarchy...
�[34mℹ�[0m Removing template-only setup and documentation...

�[32m✔ Project created successfully!�[0m
�[33mNext steps:�[0m
  1. cd ../DiagOffline
  2. git init && git add . && git commit -m "Initial commit"
  3. Open with Android Studio & Sync Gradle

Happy Coding! 🚀


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:create-new-app' (registered by plugin 'composetemplate.create.new.app').
> Expected exactly one match in /home/runner/work/ComposeTemplate/DiagOffline/feature/onboarding/presentation/src/main/java/com/example/diagoffline/feature/onboarding/presentation/OnboardingViewModel.kt, but found 2

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights from a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s

@mustafayigitt
mustafayigitt merged commit 6e61606 into main Sep 29, 2026
5 checks passed
@mustafayigitt
mustafayigitt deleted the refactor/resolve-risks-and-gaps branch September 29, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant