fix tuning offsets in tuning plugin

[Ash-86]

See discussion here #28709.

• Fixed offsets with incorrect rotations
• Added new offsets provided by @fernandomartin777 (original tuning contributor)
• Refactored tuning array for improved readability and maintainability

[Ash-86]

@fernandomartin777 would you mind double checking the tuning list?

[XiaoMigros]

Looks great overall, thanks also for the sensible property renaming. See comment below (I will take @avvvvve's definitive opinion, but do believe we already decided on the current system)

[XiaoMigros]

Mind explaining this change? I believe we already discussed this

[Ash-86]

I changed the save button to an icon because it declutters the UI and aligns with other icon-based actions. I know this was discussed before, but I wanted to propose it again here for consideration. Of course, I’ll defer to @avvvvve’s final decision.

[avvvvve]

For comparison for anyone else coming across this, these were the previous buttons:

And these are the buttons in this PR:

---

Let's not use the icon for 'Save', but I do think we could improve that button layout slightly by grouping 'Reset' with the undo/redo buttons instead of with 'Save':

'Save' and 'Reset' here are both 100px wide. @Ash-86 would you mind making that change?

[Ash-86]

Done.

[avvvvve]

Thanks!

[fernandomartin777]

@fernandomartin777 would you mind double checking the tuning list?
Currently I'm not able to remake all the research involved in finding out the way to calculate each tuning system, but I'm attaching to this message a spreadsheet containing all the calculations and the results. The first sheet has the current list of historical temperaments plus one that I created myself dividing the comma in 45 parts and distributing them progressively and the second sheet contains the Middle Eastern tunings. The other sheets has been improved along the years as a result of my research. In the first sheet in column N you can see exactly the final values that were copied and pasted into the current plugin. Any change in the values is immediately reflected in column N.

Tuning_Analyzer.ods

[avvvvve]

For some reason the usual Github review request banner isn't showing up for me here, but approving from a UX perspective!

[cbjeukendrup]

@avvvvve You can always go to the "Files changed" tab and approve from there

[fernandomartin777]

Thank you for merging my contribution. There's one observation I need to make: The following lines (more or less from 93 to 98) are somewhat redundant in their result. These tunings are a way to have those chords in the title tuned pure. However later I found out the tunings "Pure I-IV-V", "Pure I-II-V" and other entitled "just" can achieve similar results and be rotated more easily. Now it's up to the team to keep the following lines or not.
{ "id": "w42", "name": "C Cm D♭ Dm E♭ E♭m Em F Fm A♭ Am B♭", "offsets": [0, 2, -17.6, -15.6, -13.7, -11.7, 31.3, 11.7, 13.7, 15.6, 17.6, -2], "root": 0, "pure": 0, "globalOffset": 0 },
{ "id": "w43", "name": "C Cm C♯m D Dm E Em F F♯m A Am B♭", "offsets": [0, 2, -17.6, -15.6, -13.7, -11.7, -31.3, -29.3, -27.4, 15.6, -3.9, -2], "root": 0, "pure": 0, "globalOffset": 0 },
{ "id": "w44", "name": "C Cm D♭ D Dm Em F Fm A♭ Am B♭ B♭m", "offsets": [0, 2, -17.6, -15.6, -13.7, -11.7, -31.3, 11.7, 13.7, 15.6, -3.9, -2], "root": 0, "pure": 0, "globalOffset": 0 },
{ "id": "w45", "name": "C Cm D♭ E♭ Em F Fm G Gm A♭ Am Bm", "offsets": [0, 2, 3.9, -15.6, -13.7, -11.7, -9.8, 11.7, 13.7, 15.6, 17.6, -2], "root": 0, "pure": 0, "globalOffset": 0 },
{ "id": "w46", "name": "C Cm D Dm E♭ Em F♯m G Gm A♭ B♭ Bm", "offsets": [0, 2, 3.9, 5.9, -13.7, -11.7, -9.8, -7.8, 13.7, 15.6, 17.6, 19.6], "root": 0, "pure": 0, "globalOffset": 0 },
{ "id": "w47", "name": "C D E♭m E Em F♯ F♯m G G♯m B♭m B Bm", "offsets": [0, 2, 3.9, 5.9, -13.7, -11.7, -9.8, -7.8, -27.4, -25.4, -23.5, -21.5], "root": 0, "pure": 0, "globalOffset": 0 },