Skip to content

Show voice assignment shortcuts in inspector#31853

Merged
RomanPudashkin merged 2 commits intomusescore:masterfrom
XiaoMigros:tooltip-voicechange
Mar 11, 2026
Merged

Show voice assignment shortcuts in inspector#31853
RomanPudashkin merged 2 commits intomusescore:masterfrom
XiaoMigros:tooltip-voicechange

Conversation

@XiaoMigros
Copy link
Copy Markdown
Contributor

Resolves: #31611

Unfortunately requires a minor change to the UI Components, made in the first commit.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros force-pushed the tooltip-voicechange branch 2 times, most recently from 7187683 to 288beab Compare January 21, 2026 10:46
@avvvvve
Copy link
Copy Markdown

avvvvve commented Jan 21, 2026

I think this needs a rebase (am I using that term correctly here?) so that this fix is incorporated. Currently can't access properties properly in this build.

@cbjeukendrup
Copy link
Copy Markdown
Collaborator

Rebased!

am I using that term correctly here?

Yes!

@avvvvve
Copy link
Copy Markdown

avvvvve commented Jan 22, 2026

@XiaoMigros Nice! Thanks for including the shortcuts for all voices too in the context menu:

image

A couple small requests:

  1. I know the actual shortcuts are called 'Use voice 1' 'Use voice 2' etc., but I think we can just label them 'Voice 1' 'Voice 2' etc. for the individual voices.
    image

  2. For a dynamic on a single-staff instrument, I don't see a tooltip for the 'All' button. When hovering, it should say 'All voices on instrument' and show the Alt+Ctrl+0 / Opt+Cmd+0 shortcut.

@XiaoMigros
Copy link
Copy Markdown
Contributor Author

@avvvvve should all be accounted for!

image

@avvvvve
Copy link
Copy Markdown

avvvvve commented Jan 22, 2026

Thanks!

Just tested with a screenreader too, and while it's leagues better than what we had before when focusing on those buttons (it used to just say 'undefined'), I think we can improve what gets read.

Generally, when a radio button option that's part of a properties control is focused on by the screen reader, what's read is the property name followed by the button name, like this:

Position Above, radio button
Image

...but for the 'Voice assignment' buttons, the property name is not read before the button names:
image
image

Could we make it so the screenreader says the following for each button:

All:

  • For multi-staff instruments, when the 'parent' button is hovered, ideally it would read the name of whichever of the two options is currently selected:
    • Voice assignment, All voices on instrument, button
    • Voice assignment, All voices on this staff only, button
  • For single-staff instruments, it should just read:
    • Voice assignment, All voices on instrument, radio button
      • if we can't make it say 'radio button' (as opposed to 'button' as it says now), that's okay for now.

Individual voices:

  • Voice assignment, Voice 1, radio button
  • ...
  • Voice assignment, Voice 4, radio button

@avvvvve
Copy link
Copy Markdown

avvvvve commented Mar 11, 2026

Logged my last comment as a follow up: #32586

Approving the rest!

@RomanPudashkin RomanPudashkin merged commit 01c24c0 into musescore:master Mar 11, 2026
12 checks passed
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow contemporaneous editing of hairpins' and dynamics' voice assignment

4 participants