Skip to content

revert: "fix(mcp): agent mcp_config is an authoritative allowlist" (#6292) (MUL-5655) - #6314

Merged
ldnvnbl merged 1 commit into
mainfrom
revert/6292-mcp-authoritative-allowlist
Aug 3, 2026
Merged

revert: "fix(mcp): agent mcp_config is an authoritative allowlist" (#6292) (MUL-5655)#6314
ldnvnbl merged 1 commit into
mainfrom
revert/6292-mcp-authoritative-allowlist

Conversation

@multica-eve

Copy link
Copy Markdown
Collaborator

Reverts #6292 (aa349fed02f215421df5dbca9cd9752421e3b7ac).

Requested by Yushen on the 2026-08-03 release confirmation issue MUL-5655, after Preflight returned BLOCK on today's v0.4.17 window.

Why

#6292 made an agent's mcp_config an authoritative allowlist and enforced it in the daemon. To stay safe across mixed versions it added a claim-time gate: a managed, non-inheriting mcp_config claimed by a daemon that does not advertise the authoritative-mcp-v1 capability fails the task with mcp_config_daemon_outdated and returns 412 on the per-runtime path.

That gate is the blocker. If the server ships before local daemons upgrade — or during any rolling window — the next task of every existing strict-MCP agent on claude, codebuddy, codex, cursor, opencode, or openclaw fails outright instead of waiting for a newer daemon, and the failure is not auto-retryable. We do not currently have production daemon capability coverage or a count of affected agents, so the mixed-version window cannot be ruled out.

Reverting unblocks the release. The underlying defect (#6283 — an empty MCP config exposing all of the host's MCP servers) returns with the revert and needs to be re-landed once daemon rollout is confirmed.

What this restores

Scope check

git revert applied with no conflicts; 57 files, exactly the inverse of aa349fed0. No file overlap with #6291, the only commit merged after it. grep for every symbol #6292 introduced returns no residual references outside apps/docs.

Verification

Backend:

  • gofmt -l on all changed Go files — clean
  • go build ./... — clean
  • go vet ./internal/daemon/... ./internal/handler/... ./pkg/taskfailure/... ./internal/metrics/... ./cmd/multica — clean
  • go test ./internal/daemon/... ./pkg/taskfailure/... ./internal/metrics/... — all pass (this is where the reverted logic lived)
  • go test ./internal/handler/... fails in my sandbox, but identically on clean main: the shared dev Postgres is behind migration 224 (ERROR: column "session_rollout_missing" does not exist). Same tests, same messages on both refs. I did not migrate that shared DB. CI's DB-backed backend suite is the authority here.

Frontend:

  • pnpm --filter @multica/core run typecheck and pnpm --filter @multica/views run typecheck — clean
  • pnpm --filter @multica/views exec vitest run agents/ chat/ — 50 files, 395 tests, all pass
  • pnpm --filter @multica/core exec vitest run — 1178 pass, 8 fail in projects/mutations.test.tsx, realtime/use-realtime-sync-ws-instance.test.tsx, workspace/mutations.test.tsx. All three files fail the same way on clean main and none are touched by this revert.

Follow-up

…wlist (#6292)"

This reverts commit aa349fe.

Preflight flagged the server/daemon mixed-version gate as a release blocker for
today's v0.4.17 window (MUL-5655): a managed, non-inheriting mcp_config claimed
by a daemon that does not advertise authoritative-mcp-v1 fails the task with
mcp_config_daemon_outdated, and that failure is not auto-retryable. Reverting to
unblock the release; the fix should return once daemon capability coverage in
production is confirmed.

Co-authored-by: multica-agent <github@multica.ai>
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
multica-docs Ready Ready Preview Aug 3, 2026 9:41am

Request Review

multica-eve pushed a commit that referenced this pull request Aug 3, 2026
…655)

Co-authored-by: multica-agent <github@multica.ai>
@ldnvnbl
ldnvnbl merged commit 4fe94a6 into main Aug 3, 2026
10 checks passed
Bohan-J pushed a commit that referenced this pull request Aug 3, 2026
…6311)

* docs(changelog): add v0.4.17 release entry (2026-08-03) (MUL-5655)

Co-authored-by: multica-agent <github@multica.ai>

* docs(changelog): drop the MCP allowlist fix, reverted in #6314 (MUL-5655)

Co-authored-by: multica-agent <github@multica.ai>

* docs(changelog): add the Kimi resume fix from #6308 (MUL-5655)

Co-authored-by: multica-agent <github@multica.ai>

---------

Co-authored-by: Eve <eve@multica-ai.local>
Co-authored-by: multica-agent <github@multica.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants