revert: "fix(mcp): agent mcp_config is an authoritative allowlist" (#6292) (MUL-5655) - #6314
Merged
Merged
Conversation
…wlist (#6292)" This reverts commit aa349fe. Preflight flagged the server/daemon mixed-version gate as a release blocker for today's v0.4.17 window (MUL-5655): a managed, non-inheriting mcp_config claimed by a daemon that does not advertise authoritative-mcp-v1 fails the task with mcp_config_daemon_outdated, and that failure is not auto-retryable. Reverting to unblock the release; the fix should return once daemon capability coverage in production is confirmed. Co-authored-by: multica-agent <github@multica.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
multica-eve
pushed a commit
that referenced
this pull request
Aug 3, 2026
…655) Co-authored-by: multica-agent <github@multica.ai>
Bohan-J
pushed a commit
that referenced
this pull request
Aug 3, 2026
…6311) * docs(changelog): add v0.4.17 release entry (2026-08-03) (MUL-5655) Co-authored-by: multica-agent <github@multica.ai> * docs(changelog): drop the MCP allowlist fix, reverted in #6314 (MUL-5655) Co-authored-by: multica-agent <github@multica.ai> * docs(changelog): add the Kimi resume fix from #6308 (MUL-5655) Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Eve <eve@multica-ai.local> Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6292 (
aa349fed02f215421df5dbca9cd9752421e3b7ac).Requested by Yushen on the 2026-08-03 release confirmation issue MUL-5655, after Preflight returned BLOCK on today's
v0.4.17window.Why
#6292 made an agent's
mcp_configan authoritative allowlist and enforced it in the daemon. To stay safe across mixed versions it added a claim-time gate: a managed, non-inheritingmcp_configclaimed by a daemon that does not advertise theauthoritative-mcp-v1capability fails the task withmcp_config_daemon_outdatedand returns 412 on the per-runtime path.That gate is the blocker. If the server ships before local daemons upgrade — or during any rolling window — the next task of every existing strict-MCP agent on
claude,codebuddy,codex,cursor,opencode, oropenclawfails outright instead of waiting for a newer daemon, and the failure is not auto-retryable. We do not currently have production daemon capability coverage or a count of affected agents, so the mixed-version window cannot be ruled out.Reverting unblocks the release. The underlying defect (#6283 — an empty MCP config exposing all of the host's MCP servers) returns with the revert and needs to be re-landed once daemon rollout is confirmed.
What this restores
mergeRuntimeAndAgentMcpConfigadditive behaviour — a non-nullmcp_configis merged with the runtime host's MCP servers again.resolveEffectiveMcpConfig,runtime_config.mcp.inherit_runtime,mcp_config_overlay_only, theauthoritative-mcp-v1daemon capability, and themcp_config_daemon_outdatedfailure reason, along with their tests and locale strings.builtin_skills/multica-creating-agentsloses themcp_configallowlist section added by MUL-5637 fix(mcp): agent mcp_config is an authoritative allowlist #6292. The unbound-agent content from feat(runtime): unbind agents on runtime delete instead of destroying them #6220 is untouched and still present — verified.Scope check
git revertapplied with no conflicts; 57 files, exactly the inverse ofaa349fed0. No file overlap with #6291, the only commit merged after it.grepfor every symbol #6292 introduced returns no residual references outsideapps/docs.Verification
Backend:
gofmt -lon all changed Go files — cleango build ./...— cleango vet ./internal/daemon/... ./internal/handler/... ./pkg/taskfailure/... ./internal/metrics/... ./cmd/multica— cleango test ./internal/daemon/... ./pkg/taskfailure/... ./internal/metrics/...— all pass (this is where the reverted logic lived)go test ./internal/handler/...fails in my sandbox, but identically on cleanmain: the shared dev Postgres is behind migration 224 (ERROR: column "session_rollout_missing" does not exist). Same tests, same messages on both refs. I did not migrate that shared DB. CI's DB-backed backend suite is the authority here.Frontend:
pnpm --filter @multica/core run typecheckandpnpm --filter @multica/views run typecheck— cleanpnpm --filter @multica/views exec vitest run agents/ chat/— 50 files, 395 tests, all passpnpm --filter @multica/core exec vitest run— 1178 pass, 8 fail inprojects/mutations.test.tsx,realtime/use-realtime-sync-ws-instance.test.tsx,workspace/mutations.test.tsx. All three files fail the same way on cleanmainand none are touched by this revert.Follow-up
0.4.17entry; that line is being removed there.authoritative-mcp-v1coverage, and an inventory of agents with a non-null objectmcp_config.