MUL-5625: WS-2867: bound daemon workspace cache growth - #6273
Open
tangyuanjc wants to merge 7 commits into
Open
Conversation
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
|
Someone is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: multica-agent <github@multica.ai>
multica-eve
requested changes
Aug 3, 2026
multica-eve
left a comment
Collaborator
There was a problem hiding this comment.
这里有一个合并前必须修复的文件安全问题:server/internal/daemon/execenv/spotlight.go:23 直接调用 os.WriteFile 刷新 .metadata_never_index。如果该路径被先前任务替换成符号链接,下一次 Prepare / Reuse 会跟随链接并截断工作区外的目标文件。
请改为不跟随现有符号链接的安全写入。建议沿用仓库现有根标记的“同目录临时文件 + rename”原子替换模式,让符号链接本身被替换为普通空文件;至少也应先用 Lstat 拒绝非普通文件。
请同时补一个回归测试:在工作区外创建带内容的哨兵文件,把 .metadata_never_index 做成指向它的符号链接,然后调用 EnsureSpotlightExclusion;断言哨兵内容未改变,并验证标记被安全替换为普通空文件(若选择拒绝策略,则验证安全报错且目标未改变)。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.metadata_never_indexat daemon workspace rootscodex-home/.tmpas an exact managed artifact alongside.sandbox-binSafety and scope
c37d6ffd/ WS-2512data/runsoutlier is application-owned scheduled output, not runtime cache; this PR intentionally does not delete it or add a generic size capTest plan
go test -count=1 -parallel=2 ./internal/daemon/execenv ./internal/daemongit diff --check origin/main...HEADCloses WS-2867