fix(shiny): red-team polish pass — T-356..T-359 (area 7) - #275
Merged
Conversation
Four independent, low-risk EasyTrees fixes: - T-356: namespace cached upload filenames (data/tree/excel) by session$token, so two tabs on one running app process no longer clobber each other's tempdir files; tighten the onStop cleanup regex to match so it doesn't sweep other sessions' files either. - T-357: bind the missing output$instabLegend2, mirroring the sibling static legend — the "clus"/"space" plot views rendered an empty panel for their entire lifetime. - T-358: split the expensive multi-method clustering sweep out of silThreshold()'s cache key — the threshold slider only picks a winner among already-computed silhouette scores, so dragging it no longer forces a full K-means/PAM/hierarchical re-sweep. - T-359: document why the orphaned MappingQuality future is an accepted low-cost exception, contrasting with the T-311 search worker's session-end cancellation. Verified: app builds and loads cleanly in-browser with no console errors; existing testthat suites for mod-clustering, mod-treespace, mod-consensus, mod-downloads, and mod-data all pass unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output$instabLegend2, mirroring the sibling static legend (panel was permanently empty)silThreshold()'s cache key, so dragging the threshold slider no longer forces a full re-sweepMappingQualityfuture is an accepted low-cost exception (contrast with T-311's search-worker cancellation)Test plan
🤖 Generated with Claude Code