Skip to content

Only flush the link entity, fixes #12 - #13

Open
tacman wants to merge 1 commit into
mremi:masterfrom
tacman:patch-1
Open

Only flush the link entity, fixes #12#13
tacman wants to merge 1 commit into
mremi:masterfrom
tacman:patch-1

Conversation

@tacman

@tacman tacman commented Nov 2, 2017

Copy link
Copy Markdown

No description provided.

@mremi

mremi commented Nov 2, 2017

Copy link
Copy Markdown
Owner

Hi @tacman ,

Can you add some unit tests please and add a CHANGELOG.md at the root of the project:

CHANGELOG
=========

2017-11-02
----------

* Fix #12: only flush the given link

@mremi

mremi commented Nov 3, 2017

Copy link
Copy Markdown
Owner

@tacman pretty sure you'll be able to write some tests looking at the existing ones in https://github.com/mremi/UrlShortenerBundle/blob/master/Tests/Doctrine/LinkManagerTest.php.

Can you please add the CHANGELOG.md I give you above (and squash your commits to have only one).

@mremi

mremi commented Nov 15, 2017

Copy link
Copy Markdown
Owner

@tacman hi, any news?

@tacman

tacman commented Nov 15, 2017 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants