Only flush the link entity, fixes #12 - #13
Open
tacman wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @tacman , Can you add some unit tests please and add a |
Owner
|
@tacman pretty sure you'll be able to write some tests looking at the existing ones in https://github.com/mremi/UrlShortenerBundle/blob/master/Tests/Doctrine/LinkManagerTest.php. Can you please add the CHANGELOG.md I give you above (and squash your commits to have only one). |
Owner
|
@tacman hi, any news? |
Author
|
Unfortunately (and embarrassingly), I'm lousy at writing tests. I think I
can write the test in the class you've recommended, but I'm not sure how to
run them.
I keep getting:
PHP Fatal error: Class 'PHPUnit_Framework_TestCase' not found
Can you add to the documentation how to test the Bundle itself, and I'll
try to follow along and add it?
Realistically, though, my ability to write these kind of tests is very
limited. :-(
Tac
…On Wed, Nov 15, 2017 at 7:31 AM, Rémi Marseille ***@***.***> wrote:
@tacman <https://github.com/tacman> hi, any news?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAl0QcCAOtGhQGwQbeOlTy8mataMG5zvks5s2tmVgaJpZM4QPduP>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.