Repository navigation
Finish async zlib streams before sending Wiiload frames - #2
Closed
communism420 wants to merge 1 commit into
Closed
communism420 wants to merge 1 commit into
communism420 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compress_then_send_asyncin 0.6.0 flushes the zlib encoder without finishing the stream. A 4 KiB input reproduces an incomplete deflate stream at the receiver. Read the encoder to EOF before recording the sizes, then flush and rewind the supplied buffer. The public API is unchanged, and the caller's buffer is not closed.Add six regression tests covering complete sync/async frames, filename write failures, and compressed payloads, including empty input and input larger than the transfer buffer. The filename-flush production fixes are already present in 0.6.0; this PR retains tests for that behavior.
Validation on Windows with Rust 1.99: six tests with all features, four with
async, two without default features; strict Clippy for all features/targets and formatting. The async compression regression fails against current upstream and passes with this change. Validation uses protocol/decompression fixtures; no physical Wii was tested.Prepared with AI assistance.