Skip to content

feat(nimbus): fetch targeting contexts directly from each firefox app source code#14936

Merged
moibra05 merged 1 commit intomainfrom
14922
Mar 31, 2026
Merged

feat(nimbus): fetch targeting contexts directly from each firefox app source code#14936
moibra05 merged 1 commit intomainfrom
14922

Conversation

@moibra05
Copy link
Copy Markdown
Contributor

Because

  • We plan to add automated validation for Experimenter targeting configs by checking JEXL field references against the upstream targeting context definitions in the Desktop, Fenix, and iOS source code
  • Manifesttool already fetches app manifests per ref/version, but it was not downloading the targeting context source files that external config updates depend on.

This commit

  • Adds targeting_files to app config and configures it for firefox-desktop, fenix, and ios
  • Stores the files by version in each app's feature manifest as well as an unversioned copy in the root

Fixes #14922

@moibra05
Copy link
Copy Markdown
Contributor Author

moibra05 commented Mar 23, 2026

the expected updates to the manifests can be examined here #15027

@moibra05 moibra05 force-pushed the 14922 branch 5 times, most recently from fff43ac to 91d7126 Compare March 23, 2026 19:58
Copy link
Copy Markdown
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thank you @moibra05 🎉

@moibra05 moibra05 added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 4e93c8a Mar 31, 2026
32 checks passed
@moibra05 moibra05 deleted the 14922 branch March 31, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend manifesttool to fetch targeting context files alongside feature manifests

3 participants