VPN-6771: Update github tests and workflows to Qt 6.10#10955
Merged
Conversation
2d600c4 to
631cce9
Compare
Collaborator
Author
|
The windows tests are currently failing because of QTBUG-141830 and should be fixed by #10970 |
8bc80b2 to
f879ea1
Compare
d3380d8 to
25f6a01
Compare
25f6a01 to
da17420
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the tests and assorted github workflows to use Qt 6.10 wherever possible. One notable exception for now is WASM, which will be left for a separate PR.
There were two tests that required a bit of refactoring to fix:
RelWithDebInfo, which then required a bunch of cleanup to useQVERIFY()instead ofQ_ASSERT().ViewFullScreen.qmlit is wasn't scrollable into view. To resolve this, I opted to convert the factory reset into something built uponMZViewBaseand just got rid ofViewFullScreen.qmlentirely as this was the only place it was being used.Reference
JIRA Issue: VPN-6771
Checklist