Skip to content

VPN-6771: Update github tests and workflows to Qt 6.10#10955

Merged
oskirby merged 6 commits intomainfrom
naomi-qt-update-tests
Jan 27, 2026
Merged

VPN-6771: Update github tests and workflows to Qt 6.10#10955
oskirby merged 6 commits intomainfrom
naomi-qt-update-tests

Conversation

@oskirby
Copy link
Copy Markdown
Collaborator

@oskirby oskirby commented Jan 9, 2026

Description

This updates the tests and assorted github workflows to use Qt 6.10 wherever possible. One notable exception for now is WASM, which will be left for a separate PR.

There were two tests that required a bit of refactoring to fix:

  • The Windows unit tests were failing because we no longer build Qt for debug. We had to switch the unit test job to build as RelWithDebInfo, which then required a bunch of cleanup to use QVERIFY() instead of Q_ASSERT().
  • The factory reset test was failing on macOS. As best as I could tell the failure was caused by a spacing change which moved one of the UI elements beneath the nav bar, and since it was based on ViewFullScreen.qml it is wasn't scrollable into view. To resolve this, I opted to convert the factory reset into something built upon MZViewBase and just got rid of ViewFullScreen.qml entirely as this was the only place it was being used.

Reference

JIRA Issue: VPN-6771

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the naomi-qt-update-tests branch from 2d600c4 to 631cce9 Compare January 9, 2026 22:20
@oskirby
Copy link
Copy Markdown
Collaborator Author

oskirby commented Jan 15, 2026

The windows tests are currently failing because of QTBUG-141830 and should be fixed by #10970

@oskirby oskirby force-pushed the naomi-qt-update-tests branch from 8bc80b2 to f879ea1 Compare January 15, 2026 18:01
@oskirby oskirby force-pushed the naomi-qt-update-tests branch from d3380d8 to 25f6a01 Compare January 26, 2026 19:28
@oskirby oskirby force-pushed the naomi-qt-update-tests branch from 25f6a01 to da17420 Compare January 26, 2026 19:56
@oskirby oskirby marked this pull request as ready for review January 26, 2026 22:45
@oskirby oskirby requested review from mcleinman and strseb January 26, 2026 22:45
Copy link
Copy Markdown
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oskirby oskirby merged commit 18957b9 into main Jan 27, 2026
124 of 125 checks passed
@oskirby oskirby deleted the naomi-qt-update-tests branch January 27, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants