Skip to content

CI refactor#3620

Draft
EzraBrooks wants to merge 5 commits intomainfrom
reorganize-ci
Draft

CI refactor#3620
EzraBrooks wants to merge 5 commits intomainfrom
reorganize-ci

Conversation

@EzraBrooks
Copy link
Member

@EzraBrooks EzraBrooks commented Nov 25, 2025 •
edited
Loading

@mergify
Copy link

mergify bot commented Nov 25, 2025

This pull request is in conflict. Could you fix it @EzraBrooks?

@EzraBrooks
Copy link
Member Author

EzraBrooks commented Nov 25, 2025

@mergify
image

@EzraBrooks EzraBrooks force-pushed the reorganize-ci branch 2 times, most recently from d8580a9 to a996e93 Compare November 25, 2025 13:53
@EzraBrooks EzraBrooks marked this pull request as ready for review November 25, 2025 13:58
@EzraBrooks
Copy link
Member Author

EzraBrooks commented Nov 25, 2025

@nbbrooks we'll need to tweak the branch protections to merge this, because it changed the name of the required Format job (because it added a preceding CI / format / to indicate where it comes from now), but I think this is a good improvement.

@EzraBrooks EzraBrooks requested a review from nbbrooks November 25, 2025 13:59
@codecov
Copy link

codecov bot commented Nov 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.18%. Comparing base (b3c23c9) to head (a561251).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3620      +/-   ##
==========================================
- Coverage   46.19%   46.18%   -0.01%     
==========================================
  Files         726      726              
  Lines       59418    59419       +1     
  Branches     7620     7621       +1     
==========================================
- Hits        27441    27435       -6     
- Misses      31810    31817       +7     
  Partials      167      167

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link

mergify bot commented Nov 25, 2025

This pull request is in conflict. Could you fix it @EzraBrooks?

@EzraBrooks EzraBrooks changed the title Use workflow_call to organize CI sensically Corral CI jobs into one workflow, partially fix Sonar Nov 25, 2025
@EzraBrooks
Copy link
Member Author

EzraBrooks commented Nov 25, 2025

@nbbrooks I think to finish fixing Sonar here you just need to replace the SONAR_TOKEN secret with one that isn't dead.. I suspect the current SONAR_TOKEN belongs to my old admin-level credentials here.

@EzraBrooks
Copy link
Member Author

EzraBrooks commented Dec 4, 2025

@nbbrooks if you haven't been able to get your hands on a valid Sonar token because of the permissions issue we had talked about, we could just remove the SONAR_TOKEN secret for now and that should make this PR pass since it skips the sonar scan if no SONAR_TOKEN is present.

@nbbrooks
Copy link
Contributor

nbbrooks commented Dec 4, 2025

I can add a token now, just haven't gotten around to it yet 😬

@nbbrooks
Copy link
Contributor

nbbrooks commented Dec 6, 2025

#6 125.1 dpkg: error processing archive /tmp/apt-dpkg-install-FLlmxB/739-ros-rolling-moveit-task-constructor-core_0.1.4-1noble.20251124.223634_amd64.deb (--unpack):
#6 125.1 trying to overwrite '/opt/ros/rolling/lib/python3.12/site-packages/moveit/init.py', which is also in package ros-rolling-moveit-py 2.14.1-1noble.20251124.223623

@EzraBrooks
Copy link
Member Author

EzraBrooks commented Dec 8, 2025

I've been seeing that around. Rolling is borked.

@stephanie-eng stephanie-eng mentioned this pull request Dec 10, 2025
Merged
@EzraBrooks
Use workflow_call to organize CI sensically
7659d82
@EzraBrooks
Merge Sonar job into ccov job (#3621)
da6bdd3 
* Merge Sonar job into ccov job

* Modernize Sonar Scanner invocation

* Don't run if SONAR_TOKEN not available
@EzraBrooks
Copy link
Member Author

EzraBrooks commented Dec 11, 2025

ok now we're getting somewhere but I gotta fix some stuff

@EzraBrooks EzraBrooks marked this pull request as draft December 11, 2025 22:33
@EzraBrooks
Copy link
Member Author

EzraBrooks commented Dec 12, 2025

how does the actions user not have permission to create a file in the target_ws directory..

@EzraBrooks
Copy link
Member Author

EzraBrooks commented Dec 12, 2025

Okay well permissions are super borked in the CI environment apparently. Great.

@EzraBrooks EzraBrooks force-pushed the reorganize-ci branch 4 times, most recently from e7756a2 to 8760c26 Compare December 12, 2025 20:28
@EzraBrooks EzraBrooks force-pushed the reorganize-ci branch 5 times, most recently from 62c31f1 to c483ae4 Compare December 12, 2025 21:13
@EzraBrooks EzraBrooks force-pushed the reorganize-ci branch 7 times, most recently from 75a0793 to 0114dec Compare December 12, 2025 22:26
@EzraBrooks EzraBrooks changed the title Corral CI jobs into one workflow, partially fix Sonar CI refactor Dec 12, 2025
@mergify
Copy link

mergify bot commented Dec 14, 2025

This pull request is in conflict. Could you fix it @EzraBrooks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbbrooks nbbrooks Awaiting requested review from nbbrooks

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EzraBrooks @nbbrooks