Improve parking profiles - #126
Draft
MichaelKutzner wants to merge 33 commits into
Draft
Conversation
Embed parking edge details into 'car_parking::node'. This breaks the expected structure and (still) causes some unexpected results. For now only forward search is implemented. Reasons for embedding: - Reconstruction does not require additional, probably expensive search - Does not increase structs Reasons for incomplete implementation: - Breaks 'node' structure - More difficult to handle
Reverts most of previous changes in favor of a simpler encoding. This avoids possible issues with strongly modifying car_parking nodes.
As parking edges can connect different components, routing could use matches of different compenents for a more reasonable result. This should not be necessary in general. But it's noticable, when routing within an isolated component. Or when debug mode is enabled. Alternative approach: Change compent index when isolated areas are connected. This could lead to other side effects as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
This improves the parking profile by connecting parking areas with the street and foot network.
Common issues
Status
TODO