Skip to content

added comments to clearify the meaning of the "Continue" and "Stop" FilterStatus #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doujiang24 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added comments to clearify the meaning of the "Continue" and "Stop" FilterStatus #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8cffe1
added comments to clearify the meaning of the "Continue" and "Stop" F…
doujiang24 Dec 31, 2021
adb8cc5
also clearify the StreamFilterStop.
doujiang24 Dec 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions network_filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ type FilterStatus string

// FilterStatus types
const (
Continue FilterStatus = "Continue"
Stop FilterStatus = "Stop"
Continue FilterStatus = "Continue" // will continue other filters
Stop FilterStatus = "Stop" // will skip other filters
)

// FilterManager is a groups of filters
Expand Down
2 changes: 1 addition & 1 deletion stream_filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type StreamFilterStatus string
const (
// Continue filter chain iteration.
StreamFilterContinue StreamFilterStatus = "Continue"
// Do not iterate to next iterator.
// will skip other filters in the same phase (be careful)
StreamFilterStop StreamFilterStatus = "Stop"
// terminate request.
StreamFiltertermination StreamFilterStatus = "termination"
Expand Down