Skip to content

MOSIP-44737 Changed deprecated api to use new api#10559

Open
kameshsr wants to merge 2 commits into
mosip:developfrom
kameshsr:develop-MOSIP-44737.2
Open

MOSIP-44737 Changed deprecated api to use new api#10559
kameshsr wants to merge 2 commits into
mosip:developfrom
kameshsr:develop-MOSIP-44737.2

Conversation

@kameshsr

@kameshsr kameshsr commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Updated partner management settings to use the newer API path.
    • Added a configurable partner list page size, set to 100 by default.
  • Changes

    • Introduced a new partner API endpoint configuration for the latest partner manager service.
    • Removed older partner endpoint settings that are no longer needed.

Signed-off-by: kameshsr <kameshsr1338@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7dddbd3b-e12d-4334-a351-ca03d43bf23c

📥 Commits

Reviewing files that changed from the base of the PR and between b92b50b and 4f53542.

📒 Files selected for processing (1)
  • resident-default.properties

Walkthrough

This change updates Partner Manager configuration properties in resident-default.properties, adding a new PARTNER_API_URL_V2 endpoint, repointing PARTNER_API_URL to the admin-partners/v2 path, adding a page size property, and removing obsolete Partner Manager URL properties.

Changes

Partner Manager Property Updates

Layer / File(s) Summary
Update Partner Manager API URLs and page size property
resident-default.properties
Adds PARTNER_API_URL_V2, repoints PARTNER_API_URL to /admin-partners/v2, adds resident.partner.list.page.size=100, and removes PARTNER_DETAILS_NEW_URL and mosip.pms.pmp.partner.rest.uri.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A hop, a skip, a config tweak,
New URLs for partners we seek,
Old paths retired, fresh ones set,
A hundred per page, no regret,
This bunny thumps approval sweet! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: replacing a deprecated API with the new API endpoint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: kameshsr <kameshsr1338@gmail.com>
@kameshsr

kameshsr commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@CodeRabbit please review

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

@kameshsr, I'll review the changes now.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant