Skip to content

#1830 Changed to use latest version of dependent repo#258

Merged
ckm007 merged 1 commit into
mosip:developfrom
kameshsr:develop-1830
Jun 8, 2026
Merged

#1830 Changed to use latest version of dependent repo#258
ckm007 merged 1 commit into
mosip:developfrom
kameshsr:develop-1830

Conversation

@kameshsr

@kameshsr kameshsr commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated kernel dependency versions to 1.3.1-rc.1 across build configuration files

Signed-off-by: kameshsr <kameshsr1338@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR downgrades Maven kernel dependency versions from 1.4.0-SNAPSHOT to 1.3.1-rc.1 across the parent POM and five module POMs: biometrics-util, kernel-biometrics-api, kernel-biosdk-provider, kernel-cbeffutil-api, and test. Kernel-biosdk-provider also updates the logger-logback version while preserving biometrics-api at the snapshot version.

Changes

Kernel dependency version downgrade

Layer / File(s) Summary
Kernel version property updates across POMs
pom.xml, biometrics-util/pom.xml, kernel-biometrics-api/pom.xml, kernel-biosdk-provider/pom.xml, kernel-cbeffutil-api/pom.xml, test/pom.xml
Parent and module POMs consistently update kernel.bom.version and kernel.core.version from 1.4.0-SNAPSHOT to 1.3.1-rc.1. Kernel-biosdk-provider additionally updates kernel.logger.logback.version while keeping kernel.biometrics.api.version at 1.4.0-SNAPSHOT.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • mosip/bio-utils#257: Both PRs directly modify the same Maven version properties (kernel.bom.version / kernel.core.version) in the same POM files, changing the resolved kernel-bom/kernel-core versions.

Suggested reviewers

  • JanardhanBS-SyncByte
  • Prafulrakhade

Poem

🐰 A snapshot snapshot, now a release so keen,
Kernel versions rolling back to 1.3.1 serene,
Six POMs aligned, dependencies blessed,
Testing the waters, preparing for the best!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title is misleading; it claims to use the latest version of dependencies, but the changes actually downgrade from 1.4.0-SNAPSHOT to 1.3.1-rc.1, a release candidate of an earlier version. Update the title to accurately reflect the changes, such as 'Downgrade kernel dependencies to 1.3.1-rc.1' or 'Update kernel dependencies to version 1.3.1-rc.1'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@kernel-biosdk-provider/pom.xml`:
- Around line 48-51: The pom sets kernel.core.version=1.3.1-rc.1 but leaves
kernel.biometrics.api.version as 1.4.0-SNAPSHOT causing potential mismatch when
io.mosip.kernel:kernel-core is resolved; update the POM to either align
kernel.biometrics.api.version with the core RC (set
kernel.biometrics.api.version to 1.3.1-rc.1) or explicitly document and enforce
compatibility (add a comment and/or BOM/parent alignment ensuring
io.mosip.kernel:kernel-core uses ${kernel.core.version}), and confirm in the
project metadata that kernel-biometrics-api is binary compatible with
kernel-core 1.3.1-rc.1 so the dependency resolution won’t pull an unintended
core version.

In `@kernel-cbeffutil-api/pom.xml`:
- Around line 40-42: The pom mixes kernel-core at 1.3.1-rc.1 with
kernel-biometrics-api at 1.4.0-SNAPSHOT which can change CbeffXSDValidator
behavior used in tests; ensure compatibility by either aligning these dependency
versions (make kernel-core and kernel-biometrics-api use the same
release/SNAPSHOT) or updating the tests/mocks in CbeffImplTest that reference
CbeffXSDValidator to match the downgraded validator API, then run
kernel-cbeffutil-api unit tests (the provided mvn clean test script) to verify
no regressions.

In `@pom.xml`:
- Around line 53-54: The pom.xml sets kernel.bom.version and kernel.core.version
to 1.3.1-rc.1 which is not resolvable from Maven Central; update the pull
request title/description to accurately state that an RC was chosen or change
the versions to a published release (e.g., revert to 1.3.0-beta.2 or another
released version) so builds succeed, or alternatively add the appropriate
repository that hosts the RC to the <repositories> section so Maven can resolve
io.mosip.kernel:kernel-bom and io.mosip.kernel:kernel-core; touch the properties
kernel.bom.version and kernel.core.version and the PR metadata accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0e2f6db9-cc85-4078-bf37-78d07f44384d

📥 Commits

Reviewing files that changed from the base of the PR and between 8559691 and 578318b.

📒 Files selected for processing (6)
  • biometrics-util/pom.xml
  • kernel-biometrics-api/pom.xml
  • kernel-biosdk-provider/pom.xml
  • kernel-cbeffutil-api/pom.xml
  • pom.xml
  • test/pom.xml

Comment thread kernel-biosdk-provider/pom.xml
Comment thread kernel-cbeffutil-api/pom.xml
Comment thread pom.xml
@ckm007 ckm007 merged commit db97a05 into mosip:develop Jun 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants