#1830 Changed to use latest version of dependent repo#258
Conversation
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
WalkthroughThis PR downgrades Maven kernel dependency versions from ChangesKernel dependency version downgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kernel-biosdk-provider/pom.xml`:
- Around line 48-51: The pom sets kernel.core.version=1.3.1-rc.1 but leaves
kernel.biometrics.api.version as 1.4.0-SNAPSHOT causing potential mismatch when
io.mosip.kernel:kernel-core is resolved; update the POM to either align
kernel.biometrics.api.version with the core RC (set
kernel.biometrics.api.version to 1.3.1-rc.1) or explicitly document and enforce
compatibility (add a comment and/or BOM/parent alignment ensuring
io.mosip.kernel:kernel-core uses ${kernel.core.version}), and confirm in the
project metadata that kernel-biometrics-api is binary compatible with
kernel-core 1.3.1-rc.1 so the dependency resolution won’t pull an unintended
core version.
In `@kernel-cbeffutil-api/pom.xml`:
- Around line 40-42: The pom mixes kernel-core at 1.3.1-rc.1 with
kernel-biometrics-api at 1.4.0-SNAPSHOT which can change CbeffXSDValidator
behavior used in tests; ensure compatibility by either aligning these dependency
versions (make kernel-core and kernel-biometrics-api use the same
release/SNAPSHOT) or updating the tests/mocks in CbeffImplTest that reference
CbeffXSDValidator to match the downgraded validator API, then run
kernel-cbeffutil-api unit tests (the provided mvn clean test script) to verify
no regressions.
In `@pom.xml`:
- Around line 53-54: The pom.xml sets kernel.bom.version and kernel.core.version
to 1.3.1-rc.1 which is not resolvable from Maven Central; update the pull
request title/description to accurately state that an RC was chosen or change
the versions to a published release (e.g., revert to 1.3.0-beta.2 or another
released version) so builds succeed, or alternatively add the appropriate
repository that hosts the RC to the <repositories> section so Maven can resolve
io.mosip.kernel:kernel-bom and io.mosip.kernel:kernel-core; touch the properties
kernel.bom.version and kernel.core.version and the PR metadata accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0e2f6db9-cc85-4078-bf37-78d07f44384d
📒 Files selected for processing (6)
biometrics-util/pom.xmlkernel-biometrics-api/pom.xmlkernel-biosdk-provider/pom.xmlkernel-cbeffutil-api/pom.xmlpom.xmltest/pom.xml
Summary by CodeRabbit