Move release-1.3.x changes to develop#256
Closed
kameshsr wants to merge 69 commits into
Closed
Conversation
Signed-off-by: techno-467 <prafulrakhade02@gmail.com>
[MOSIP-41674] central migration changes
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
[MOSIP-41674] central sonatype migration changes
Signed-off-by: Janardhan B S <72377118+JanardhanBS-SyncByte@users.noreply.github.com>
Signed-off-by: JanardhanBS-SyncByte <janardhan@syncbyte.in>
Signed-off-by: JanardhanBS-SyncByte <janardhan@syncbyte.in>
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>
This file lists third-party packages used in the project along with their licenses and version information. Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Removed JaCoCo Maven Plugin details from notices. Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
…trics-api) This file lists third-party packages used in the project along with their licenses and homepages. It includes packages such as MOSIP Kernel, Spring Boot, Jackson, and various Apache Maven plugins. Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
…bosdk-provider) Added third-party notices and license information. Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
…cbeffutil-api) Updated third-party notices with package details and licenses. Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Add NOTICE file with third-party component attributions Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
…osip#218) Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
* [MOSIP-42183] : Updated POM Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com> * Fix formatting issues in pom.xml Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com> --------- Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: Rakshithasai123 <rakshithasai2002@gmail.com>
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
* MOSIP-37256: readme file update Signed-off-by: nagendra0721 <nagendra0718@gmail.com> * MOSIP-37256: readme file update Signed-off-by: nagendra0721 <nagendra0718@gmail.com> * MOSIP-37256: add missing sonar profile to pom file Signed-off-by: nagendra0721 <nagendra0718@gmail.com> --------- Signed-off-by: nagendra0721 <nagendra0718@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Prafulrakhade <Prafulrakhade@users.noreply.github.com>
Update THIRD-PARTY-NOTICES with package information(bio-utils/kernel-cbeffutil-api)
Create Apache-2.0.txt
Create NOTICE.txt for third-party licenses
Create NOTICES.txt
MOSIP-43815 - Add THIRD-PARTY-NOTICES file with package licenses
Create NOTICES.txt
Update THIRD-PARTY-NOTICES.txt with license details(bio-utils/kernel-bosdk-provider)
Create NOTICES.txt
Add third-party notices and license information(bio-util/kernel-biome…
Signed-off-by: amanbh321 <Aman.Bahuguna@iiitb.ac.in>
…sip#246) * MOSIP-44867 SNAPSHOT changes for licensing folder space issue fix Signed-off-by: kameshsr <kameshsr1338@gmail.com> * corrected pom Signed-off-by: kameshsr <kameshsr1338@gmail.com> --------- Signed-off-by: kameshsr <kameshsr1338@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Prafulrakhade <Prafulrakhade@users.noreply.github.com>
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
WalkthroughThis PR releases v1.3.1 of the MOSIP biometrics utility modules with version upgrades across all Maven POMs, comprehensive third-party license documentation, and targeted enhancements to the biometrics API serialization and XML validation layers. ChangesVersion Release and Build Configuration
Third-Party Licensing and Documentation
Biometrics API Serialization and Validation Enhancements
CBEFF Implementation Consolidation
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
biometrics-util/pom.xml (1)
156-162:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFix
junit-bomBOM import placement inbiometrics-util/pom.xml
org.junit:junit-bomis declared in the regular<dependencies>section with<type>pom</type>and<scope>import</scope>. Maven only allowsscope=importforpomdependencies inside<dependencyManagement>, so the BOM won’t be applied correctly (and may fail model validation).<dependency> <groupId>org.junit</groupId> <artifactId>junit-bom</artifactId> <version>${org.junit.version}</version> <type>pom</type> <scope>import</scope> </dependency>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@biometrics-util/pom.xml` around lines 156 - 162, The junit-bom entry is declared as a <dependency> with <type>pom</type> and <scope>import</scope>, which is invalid; move the org.junit:junit-bom declaration out of the regular <dependencies> block and place it inside the <dependencyManagement> section of biometrics-util/pom.xml (keeping the groupId artifactId version and type/pom/scope/import metadata) so Maven applies the BOM correctly and remove the invalid entry from <dependencies>.
♻️ Duplicate comments (1)
kernel-biosdk-provider/THIRD-PARTY-NOTICES.txt (1)
122-125:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winH2 Database license is incomplete.
Same issue as in
kernel-biometrics-api/THIRD-PARTY-NOTICES.txt: H2 Database should be listed as "EPL-1.0 OR MPL-2.0" to reflect its dual-license status.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@kernel-biosdk-provider/THIRD-PARTY-NOTICES.txt` around lines 122 - 125, Update the H2 Database entry in THIRD-PARTY-NOTICES by changing the License line for the "Package: H2 Database" entry from "EPL 1.0" to the correct dual-license string "EPL-1.0 OR MPL-2.0", ensuring the Homepage and separator lines remain unchanged; locate the block starting with "Package: H2 Database" and replace only the License value to reflect the dual-license status.
🧹 Nitpick comments (1)
kernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/IntArrayToByteArrayDeserializer.java (1)
50-52: ⚡ Quick winUse the active deserialization context instead of a private
ObjectMapper.Reading the array through a separate
ObjectMappermakes this field ignore the owning mapper's deserialization configuration and diagnostics. It also makes the localSTRICT_DUPLICATE_DETECTIONsetting misleading, because it cannot reconfigure the parser that's already in flight.context.readValue(parser, int[].class)keeps the behavior aligned with the caller's Jackson pipeline and lets you drop the extra global mapper.Suggested fix
-import com.fasterxml.jackson.databind.DeserializationFeature; -import com.fasterxml.jackson.databind.ObjectMapper; @@ - private static final ObjectMapper MAPPER = new ObjectMapper() - .disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES) - .disable(JsonParser.Feature.STRICT_DUPLICATE_DETECTION); - private static final Base64.Decoder STD_DECODER = Base64.getDecoder(); @@ - int[] intArray = MAPPER.readValue(parser, int[].class); + int[] intArray = context.readValue(parser, int[].class);Also applies to: 103-104
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@kernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/IntArrayToByteArrayDeserializer.java` around lines 50 - 52, The deserializer creates and uses a private ObjectMapper which ignores the caller's deserialization context and parser settings; update IntArrayToByteArrayDeserializer to use the provided DeserializationContext and JsonParser instead (e.g., call context.readValue(parser, int[].class) or equivalent within the deserialize(...) method) and remove the static MAPPER; apply the same change to the other occurrence around lines 103-104 so all int[] reads use the context-provided readValue rather than a separate ObjectMapper.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@kernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/ByteArrayToIntArraySerializer.java`:
- Around line 88-93: ByteArrayToIntArraySerializer currently builds a full int[]
(intArray) before writing, causing large extra allocations for biometric blobs;
change the serialize implementation to stream the bytes directly into the
JsonGenerator instead of materializing an int[]: call gen.writeStartArray(),
loop over the input byte[] (value) and for each element call
gen.writeNumber(useUnsigned ? Byte.toUnsignedInt(value[i]) : value[i]), then
call gen.writeEndArray(); keep the existing useUnsigned logic and method/class
names (ByteArrayToIntArraySerializer and its serialize(...) method) so the
change is localized and avoids O(n) extra memory per serialization.
In `@kernel-biometrics-api/THIRD-PARTY-NOTICES.txt`:
- Around line 122-125: The H2 Database entry in this THIRD-PARTY-NOTICES file
incorrectly lists the license as "EPL 1.0"; update the H2 Database package
license string to the canonical dual-license text "EPL-1.0 OR MPL-2.0" to match
the root and other module notices, and ensure formatting/capitalization matches
the other notices (e.g., "H2 Database" package name and separator lines remain
unchanged).
In `@kernel-cbeffutil-api/pom.xml`:
- Around line 87-91: The POM contains a duplicate dependency entry for
io.mosip.kernel:kernel-biometrics-api using ${kernel.biometrics.api.version};
remove the second declaration (the repeated <dependency> block that repeats
groupId io.mosip.kernel and artifactId kernel-biometrics-api) so the dependency
appears only once in the <dependencies> section, leaving the first/primary
declaration with the version property intact.
In `@THIRD-PARTY-NOTICES.txt`:
- Around line 6-9: Update the package version entry in THIRD-PARTY-NOTICES.txt
for "MOSIP Bio Utils" to match the release target by replacing "Version:
1.3.0-SNAPSHOT" with "Version: 1.3.1"; ensure the line under the "Package: MOSIP
Bio Utils" header is changed and consistency is preserved with the rest of the
file.
---
Outside diff comments:
In `@biometrics-util/pom.xml`:
- Around line 156-162: The junit-bom entry is declared as a <dependency> with
<type>pom</type> and <scope>import</scope>, which is invalid; move the
org.junit:junit-bom declaration out of the regular <dependencies> block and
place it inside the <dependencyManagement> section of biometrics-util/pom.xml
(keeping the groupId artifactId version and type/pom/scope/import metadata) so
Maven applies the BOM correctly and remove the invalid entry from
<dependencies>.
---
Duplicate comments:
In `@kernel-biosdk-provider/THIRD-PARTY-NOTICES.txt`:
- Around line 122-125: Update the H2 Database entry in THIRD-PARTY-NOTICES by
changing the License line for the "Package: H2 Database" entry from "EPL 1.0" to
the correct dual-license string "EPL-1.0 OR MPL-2.0", ensuring the Homepage and
separator lines remain unchanged; locate the block starting with "Package: H2
Database" and replace only the License value to reflect the dual-license status.
---
Nitpick comments:
In
`@kernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/IntArrayToByteArrayDeserializer.java`:
- Around line 50-52: The deserializer creates and uses a private ObjectMapper
which ignores the caller's deserialization context and parser settings; update
IntArrayToByteArrayDeserializer to use the provided DeserializationContext and
JsonParser instead (e.g., call context.readValue(parser, int[].class) or
equivalent within the deserialize(...) method) and remove the static MAPPER;
apply the same change to the other occurrence around lines 103-104 so all int[]
reads use the context-provided readValue rather than a separate ObjectMapper.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a85ddac8-b5ad-4818-b0c4-75c8affa719a
📒 Files selected for processing (22)
README.mdTHIRD-PARTY-NOTICES.txtbiometrics-util/pom.xmlkernel-biometrics-api/NOTICEkernel-biometrics-api/THIRD-PARTY-NOTICES.txtkernel-biometrics-api/pom.xmlkernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/commons/CbeffValidator.javakernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/ByteArrayToIntArraySerializer.javakernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/IntArrayToByteArrayDeserializer.javakernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/ObjectFactory.javakernel-biometrics-api/src/test/io/mosip/kernel/biometrics/CbeffValidatorTest.javakernel-biometrics-api/src/test/resources/schema/updatedcbeff.xsdkernel-biosdk-provider/THIRD-PARTY-NOTICES.txtkernel-biosdk-provider/pom.xmlkernel-cbeffutil-api/NOTICEkernel-cbeffutil-api/README.mdkernel-cbeffutil-api/THIRD-PARTY-NOTICES.txtkernel-cbeffutil-api/pom.xmlkernel-cbeffutil-api/src/main/java/io/mosip/kernel/cbeffutil/impl/CbeffImpl.javakernel-cbeffutil-api/src/test/java/io/mosip/kernel/cbeffutil/test/CbeffImplTest.javapom.xmltest/pom.xml
💤 Files with no reviewable changes (2)
- kernel-cbeffutil-api/src/main/java/io/mosip/kernel/cbeffutil/impl/CbeffImpl.java
- kernel-cbeffutil-api/src/test/java/io/mosip/kernel/cbeffutil/test/CbeffImplTest.java
Comment on lines
+88
to
+93
| // Convert byte[] to int[] for writing | ||
| int[] intArray = new int[value.length]; | ||
| for (int i = 0; i < value.length; i++) { | ||
| intArray[i] = useUnsigned ? Byte.toUnsignedInt(value[i]) : value[i]; | ||
| } | ||
| gen.writeArray(intArray, 0, intArray.length); |
There was a problem hiding this comment.
Avoid materializing a second array for biometric payloads.
BIR.bdb and BIR.sb are raw biometric blobs, so building a same-length int[] here turns every serialization into a full extra allocation with ~4x per-element overhead before Jackson even writes anything. That is a noticeable heap regression on large BDB/SB payloads and can push this path into GC churn or OOMs. Please keep the write loop streaming directly to JsonGenerator so serialization stays O(1) in extra space.
Suggested fix
- // Convert byte[] to int[] for writing
- int[] intArray = new int[value.length];
- for (int i = 0; i < value.length; i++) {
- intArray[i] = useUnsigned ? Byte.toUnsignedInt(value[i]) : value[i];
- }
- gen.writeArray(intArray, 0, intArray.length);
+ gen.writeStartArray(value.length);
+ for (byte b : value) {
+ gen.writeNumber(useUnsigned ? Byte.toUnsignedInt(b) : b);
+ }
+ gen.writeEndArray();📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // Convert byte[] to int[] for writing | |
| int[] intArray = new int[value.length]; | |
| for (int i = 0; i < value.length; i++) { | |
| intArray[i] = useUnsigned ? Byte.toUnsignedInt(value[i]) : value[i]; | |
| } | |
| gen.writeArray(intArray, 0, intArray.length); | |
| gen.writeStartArray(value.length); | |
| for (byte b : value) { | |
| gen.writeNumber(useUnsigned ? Byte.toUnsignedInt(b) : b); | |
| } | |
| gen.writeEndArray(); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@kernel-biometrics-api/src/main/java/io/mosip/kernel/biometrics/entities/ByteArrayToIntArraySerializer.java`
around lines 88 - 93, ByteArrayToIntArraySerializer currently builds a full
int[] (intArray) before writing, causing large extra allocations for biometric
blobs; change the serialize implementation to stream the bytes directly into the
JsonGenerator instead of materializing an int[]: call gen.writeStartArray(),
loop over the input byte[] (value) and for each element call
gen.writeNumber(useUnsigned ? Byte.toUnsignedInt(value[i]) : value[i]), then
call gen.writeEndArray(); keep the existing useUnsigned logic and method/class
names (ByteArrayToIntArraySerializer and its serialize(...) method) so the
change is localized and avoids O(n) extra memory per serialization.
Comment on lines
+122
to
+125
| Package: H2 Database | ||
| License: EPL 1.0 | ||
| Homepage: https://www.h2database.com | ||
| ================================================================================ |
There was a problem hiding this comment.
H2 Database license is inconsistent across THIRD-PARTY-NOTICES files.
This file lists H2 Database as "EPL 1.0", but the root THIRD-PARTY-NOTICES.txt (line 148) lists it as "EPL-1.0 OR MPL-2.0", and kernel-cbeffutil-api/THIRD-PARTY-NOTICES.txt (line 123) lists it as "EPL 1.0 or MPL 2.0". H2 Database is officially dual-licensed under EPL-1.0 OR MPL-2.0.
🔧 Suggested fix
Package: H2 Database
-License: EPL 1.0
+License: EPL-1.0 OR MPL-2.0
Homepage: https://www.h2database.com📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Package: H2 Database | |
| License: EPL 1.0 | |
| Homepage: https://www.h2database.com | |
| ================================================================================ | |
| Package: H2 Database | |
| License: EPL-1.0 OR MPL-2.0 | |
| Homepage: https://www.h2database.com | |
| ================================================================================ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@kernel-biometrics-api/THIRD-PARTY-NOTICES.txt` around lines 122 - 125, The H2
Database entry in this THIRD-PARTY-NOTICES file incorrectly lists the license as
"EPL 1.0"; update the H2 Database package license string to the canonical
dual-license text "EPL-1.0 OR MPL-2.0" to match the root and other module
notices, and ensure formatting/capitalization matches the other notices (e.g.,
"H2 Database" package name and separator lines remain unchanged).
Comment on lines
+87
to
+91
| <dependency> | ||
| <groupId>io.mosip.kernel</groupId> | ||
| <artifactId>kernel-biometrics-api</artifactId> | ||
| <version>${kernel.biometrics.api.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import xml.etree.ElementTree as ET
from collections import Counter
pom = "kernel-cbeffutil-api/pom.xml"
ns = {"m": "http://maven.apache.org/POM/4.0.0"}
root = ET.parse(pom).getroot()
deps = []
for dep in root.findall("./m:dependencies/m:dependency", ns):
deps.append((
dep.findtext("m:groupId", namespaces=ns),
dep.findtext("m:artifactId", namespaces=ns),
dep.findtext("m:version", namespaces=ns),
dep.findtext("m:scope", namespaces=ns) or "compile",
))
for dep, count in Counter(deps).items():
if count > 1:
print("duplicate:", count, dep)
PY
nl -ba kernel-cbeffutil-api/pom.xml | sed -n '62,92p'Repository: mosip/bio-utils
Length of output: 226
🏁 Script executed:
#!/bin/bash
set -euo pipefail
pom="kernel-cbeffutil-api/pom.xml"
echo "== Snippet around lines 60-100 =="
awk 'NR>=55 && NR<=105 {printf "%4d:%s\n", NR, $0}' "$pom" | sed -n '1,60p'
echo
echo "== Dependency duplicates (dependencies section only) =="
python3 - <<'PY'
import xml.etree.ElementTree as ET
from collections import Counter
pom = "kernel-cbeffutil-api/pom.xml"
ns = {"m": "http://maven.apache.org/POM/4.0.0"}
root = ET.parse(pom).getroot()
deps = []
for dep in root.findall("./m:dependencies/m:dependency", ns):
deps.append((
dep.findtext("m:groupId", namespaces=ns),
dep.findtext("m:artifactId", namespaces=ns),
dep.findtext("m:version", namespaces=ns),
dep.findtext("m:scope", namespaces=ns) or "compile",
))
for (g,a,v,s), count in Counter(deps).items():
if count > 1:
print(f"duplicate: {count} ({g}, {a}, {v}, {s})")
PYRepository: mosip/bio-utils
Length of output: 1879
Remove the duplicate kernel-biometrics-api dependency entry
kernel-cbeffutil-api/pom.xml declares io.mosip.kernel:kernel-biometrics-api twice in <dependencies> (once around lines 67-71 and again around 87-91) with the same version property (defaulting to compile scope). Remove the second declaration to avoid duplicate dependency noise.
Suggested cleanup
- <dependency>
- <groupId>io.mosip.kernel</groupId>
- <artifactId>kernel-biometrics-api</artifactId>
- <version>${kernel.biometrics.api.version}</version>
- </dependency>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <dependency> | |
| <groupId>io.mosip.kernel</groupId> | |
| <artifactId>kernel-biometrics-api</artifactId> | |
| <version>${kernel.biometrics.api.version}</version> | |
| </dependency> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@kernel-cbeffutil-api/pom.xml` around lines 87 - 91, The POM contains a
duplicate dependency entry for io.mosip.kernel:kernel-biometrics-api using
${kernel.biometrics.api.version}; remove the second declaration (the repeated
<dependency> block that repeats groupId io.mosip.kernel and artifactId
kernel-biometrics-api) so the dependency appears only once in the <dependencies>
section, leaving the first/primary declaration with the version property intact.
Comment on lines
+6
to
+9
| Package: MOSIP Bio Utils | ||
| Version: 1.3.0-SNAPSHOT | ||
| License: Mozilla Public License 2.0 (Inferred from project’s official repository) | ||
| Homepage: https://github.com/mosip/bio-utils |
There was a problem hiding this comment.
Update version to match the release target.
The package version is listed as 1.3.0-SNAPSHOT, but this PR is releasing v1.3.1 according to the PR objectives and AI summary.
📝 Suggested fix
Package: MOSIP Bio Utils
-Version: 1.3.0-SNAPSHOT
+Version: 1.3.1
License: Mozilla Public License 2.0 (Inferred from project's official repository)
Homepage: https://github.com/mosip/bio-utils📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Package: MOSIP Bio Utils | |
| Version: 1.3.0-SNAPSHOT | |
| License: Mozilla Public License 2.0 (Inferred from project’s official repository) | |
| Homepage: https://github.com/mosip/bio-utils | |
| Package: MOSIP Bio Utils | |
| Version: 1.3.1 | |
| License: Mozilla Public License 2.0 (Inferred from project's official repository) | |
| Homepage: https://github.com/mosip/bio-utils |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@THIRD-PARTY-NOTICES.txt` around lines 6 - 9, Update the package version entry
in THIRD-PARTY-NOTICES.txt for "MOSIP Bio Utils" to match the release target by
replacing "Version: 1.3.0-SNAPSHOT" with "Version: 1.3.1"; ensure the line under
the "Package: MOSIP Bio Utils" header is changed and consistency is preserved
with the rest of the file.
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Documentation
release-1.3.xbranch