fix(bundler): never skip recovery transfers in Paraswap/ERC20Wrapper ops#518
Merged
fix(bundler): never skip recovery transfers in Paraswap/ERC20Wrapper ops#518
Conversation
…per ops Recovery erc20Transfer calls that sweep leftover tokens from paraswapAdapter and erc20WrapperAdapter back to generalAdapter1 now always have skipRevert=false, preventing tokens from being stranded on adapters when an integrator enables skipRevert=true for best-effort swaps. Resolves SDK-94 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 tasks
Foulks-Plb
previously approved these changes
Mar 9, 2026
Tests that Paraswap_Buy, Paraswap_Sell, erc20WrapperDepositFor, and erc20WrapperWithdrawTo recovery transfers always have skipRevert=false, even when the operation itself has skipRevert=true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Foulks-Plb
approved these changes
Mar 9, 2026
oumar-fall
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
erc20Transfercalls that sweep leftover tokens fromparaswapAdapteranderc20WrapperAdapterback togeneralAdapter1now always haveskipRevert: falseskipRevert=truefor best-effort swapsoperation.skipRevertto preserve best-effort semanticsTest plan
Resolves SDK-94, SDK-93
🤖 Generated with Claude Code