smite: Also check for Self::Target in is_timeout#41
Open
ekzyis wants to merge 1 commit intomorehouse:masterfrom
Open
smite: Also check for Self::Target in is_timeout#41ekzyis wants to merge 1 commit intomorehouse:masterfrom
ekzyis wants to merge 1 commit intomorehouse:masterfrom
Conversation
ekzyis
force-pushed
the
include-targeterror-in-is-timeout
branch
from
eda5fac to
e7cf611
Compare
ekzyis
force-pushed
the
include-targeterror-in-is-timeout
branch
from
e7cf611 to
7d6028e
Compare
ekzyis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScenarioError::is_timeoutdid not consider timeout errors derived fromTargetError. This is currently not a bug, becauseis_timeoutis only used to checkping_pongerrors, andping_pongalways returnsConnectionErrororBoltError, but it might become one.