smite: add revoke_and_ack message codec implementation#34
Open
kartikangiras wants to merge 1 commit intomorehouse:masterfrom
Open
smite: add revoke_and_ack message codec implementation#34kartikangiras wants to merge 1 commit intomorehouse:masterfrom
kartikangiras wants to merge 1 commit intomorehouse:masterfrom
Conversation
kushagra0902
reviewed
Apr 4, 2026
kushagra0902
left a comment
There was a problem hiding this comment.
The PR in general looks good and has all the fields from the Bolt-02 type 133. There is a small naming/intent problem in one of the tests mentioned.
| let secret1 = [0x01; 32]; | ||
| let secret2 = [0x02; 32]; | ||
|
|
||
| for secret_bytes in &[secret1, secret2] { |
There was a problem hiding this comment.
The test does not generate different public keys; it uses the same constant key in every iteration, so the test name is misleading, as the code let pk = PublicKey::from_slice(&[0x02; 33]).expect("valid public key"); Generates same keys in every iteration
It would be better to use this:
let sk1 = SecretKey::from_slice(&[0x01; 32]).unwrap();
let sk2 = SecretKey::from_slice(&[0x03; 32]).unwrap();
for sk in &[sk1, sk2] {
let pk = PublicKey::from_secret_key(&secp, sk);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Revoke Ack message codec.
relates to #5