Repository navigation
h2c: Enable health checking for connections if they are idle - #181
Merged
Merged
Conversation
We don't have any health checking configured, so if there is a dead connection, we keep it around until the request fails due to hitting the context deadline This PR adds the ReadIdleTimeout which enables the health checking, waiting up to 30s for an idle connection to respond to a ping before closing it and eviciting it
domgoodwin
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have any health checking configured, so if there is a dead connection, we keep it around until the request fails due to hitting the context deadline
This PR adds the ReadIdleTimeout which enables the health checking, if there is no frames within 30s, we will send a ping and wait 10s for a response, closing the connection if we don't get anything