EF-287: Update projects to help test discovery #265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
adelinowona and
Copilot
and removed request for
adelinowona
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses test discovery issues with .NET 10 and the latest test runner by standardizing project configuration across test projects.
- Adds explicit
TargetFrameworkdeclarations to UnitTests and FunctionalTests projects - Standardizes
DefineConstantsacross all configurations to include TRACE and DEBUG/RELEASE flags consistently - Ensures all test projects have uniform configuration property definitions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MongoDB.EntityFrameworkCore.UnitTests.csproj | Adds TargetFramework (net8.0) and complete DefineConstants properties for all configurations (Debug, Release, Debug EF9, Release EF9) |
| MongoDB.EntityFrameworkCore.SpecificationTests.csproj | Updates DefineConstants for Debug and Release configurations to include TRACE and DEBUG/RELEASE flags for consistency with EF9 configurations |
| MongoDB.EntityFrameworkCore.FunctionalTests.csproj | Adds TargetFramework (net8.0) and updates DefineConstants for Debug and Release configurations to match the pattern used in EF9 configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/MongoDB.EntityFrameworkCore.UnitTests/MongoDB.EntityFrameworkCore.UnitTests.csproj
Show resolved
Hide resolved
...ngoDB.EntityFrameworkCore.FunctionalTests/MongoDB.EntityFrameworkCore.FunctionalTests.csproj
Show resolved
Hide resolved
With .NET 10 and the latest test runner, test discovery was not working reliably for me. I added a target for each project to fix it, and updated the defines to be consistent across projects.
ajcvickers
force-pushed
the
1217_BiddyBiddyBiddy
branch
from
82283a4 to
e44f900
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
No longer needed with latest Rider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With .NET 10 and the latest test runner, test discovery was not working reliably for me. I added a target for each project to fix it, and updated the defines to be consistent across projects.