Clarify human and agent setup - #4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82d355f508
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 3. Install with `uv tool install threadlens` or upgrade with | ||
| `uv tool upgrade threadlens`. If uv is unavailable, use | ||
| `pipx install threadlens` / `pipx upgrade threadlens`. If neither tool exists, | ||
| explain the smallest safe prerequisite and ask before installing it. |
There was a problem hiding this comment.
Use the installer that owns the existing installation
When Threadlens is already installed by pipx but uv is also available, this procedure directs the agent to run uv tool upgrade threadlens; that command only upgrades uv-installed tools (uv tool upgrade --help describes it as “Upgrade installed tools”) and exits with “threadlens is not installed” in this scenario. Detect whether the resolved command belongs to uv or pipx and use the corresponding upgrade command so an otherwise valid existing installation does not derail setup.
Useful? React with 👍 / 👎.
| The report includes the affected source, path, and read error. Fix permissions | ||
| at the narrowest layer that blocked access: |
There was a problem hiding this comment.
Avoid promising permission errors that doctor cannot discover
When access is denied while traversing a standard session directory—the permission problem this section is intended to diagnose—source_paths() returns only files it successfully discovers, while inaccessible glob roots and failed .exists() candidates are omitted. Consequently cmd_doctor() can report the source as ok (0/0) with no path or read error, so users cannot follow this troubleshooting advice; explicitly probe and report candidate roots or document that doctor cannot identify this class of denial.
Useful? React with 👍 / 👎.
Summary
Validation