Repository navigation
FIX-#5635: Correct reset_index column collision check for custom index names - #7716
Open
puja-hansitha wants to merge 1 commit into
Open
puja-hansitha wants to merge 1 commit into
puja-hansitha wants to merge 1 commit into
Conversation
…r custom index names Signed-off-by: Puja <katepallipujahansitha@gmail.com>
puja-hansitha
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
October 11, 2026 06:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sreset_indexraises ValueError ("cannot insert level_0, already exists") even if the index has a custom name #5635docs/development/architecture.rstis up-to-dateDescription
In
BasePandasDataset.reset_index, an eager check assumed that having"level_0"and"index"incolumnswould always collide upon reset, regardless of whether the index had a custom name. This caused:reset_indexto raiseValueError: cannot insert level_0, already existseven when the index had a custom name that would not collide (resolves BUG:reset_indexraises ValueError ("cannot insert level_0, already exists") even if the index has a custom name #5635).ValueError).allow_duplicates=True.This PR updates
BasePandasDataset.reset_indexto determine the exact inserted column names and validate for collisions in reverse order of level insertion, fully matching pandas behavior.