Repository navigation
Report a stored prefill/decode pair's state when its routing is missing - #555
Merged
dennis-upbound merged 2 commits intoOct 22, 2026
Merged
Conversation
A PrefillDecode replica stored before router became required gets a fatal result, which leaves its pods and router serving. The function returned before deriving ModelAccepted and ModelReady, and Crossplane marks every condition a function doesn't set Unknown with reason FatalError. A pair that still served reported ModelReady=Unknown. The function now derives both conditions from observed state whether or not composing stops. The event announcing the first reconcile moves into the composing path, so a fatal result doesn't claim to be composing. The default picker helper is now _default_unified_picker, since only a Unified replica runs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dennis Ramdass <dennis@upbound.io>
Collaborator
Author
negz
approved these changes
Oct 22, 2026
| # Conditions are derived from observed state even when composing stops | ||
| # with a fatal result. Crossplane keeps the conditions a function sets | ||
| # and marks the rest Unknown, so skipping them would report a pair that | ||
| # still serves as ModelReady=Unknown. |
Collaborator
There was a problem hiding this comment.
This feels like the agent narrating this change. I don't think we need this comment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dennis Ramdass <dennis@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
A
PrefillDecodereplica stored beforerouterbecame required gets a fatal result, which leaves its pods and router serving until its deployment adds its routing.compose-model-replicareturned before derivingModelAcceptedandModelReady, and Crossplane marks every condition a function doesn't setUnknownwith reasonFatalError, so a pair that still served reportedModelReady=Unknown.The function now derives both conditions from observed state whether or not composing stops. The "Composing" event for the first reconcile moves into the composing path, so a fatal result doesn't announce that it's composing.
PrefillDecodeRoutingMissingnow models a stored pair whose workloads are Ready, and expects the fatal result besideModelAccepted=TrueandModelReady=True.The default picker helper is renamed
_default_unified_picker, since only aUnifiedreplica runs it.Both come from @negz's review of #529.
I have:
nix flake check(or./nix.sh flake check) and made sure it passes.git commit -s.🤖 Generated with Claude Code